From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
Francesco Allertsen <fallertsen@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: Intel i915 freeze on latest git
Date: Tue, 01 Feb 2011 16:57:37 +0000 [thread overview]
Message-ID: <b7da2f$qaam25@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <20110201083112.3cfefc3a@jbarnes-desktop>
On Tue, 1 Feb 2011 08:31:12 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> The bisect is interesting, I'd have expected a failure when we
> re-enabled rc6 on ILK or when we fixed up the ring buffer init.
Yes, that was my instinct as well.
Though that patch does do have one subtlety:
ironlake_enable_rc6():
+ I915_WRITE(RSTDBYCTL, I915_READ(RSTDBYCTL) & ~RCX_SW_EXIT);
So it appears the patch may in fact be enabling render standby, when it
was actually dropped in
commit 88271da3f3da75d6eaef5e768c82a1627edf7088
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date: Wed Jan 5 12:01:24 2011 -0800
drm/i915: re-enable rc6 support for Ironlake+
intel_enable_clock_gating():
- I915_WRITE(MCHBAR_RENDER_STANDBY,
- I915_READ(MCHBAR_RENDER_STANDBY) & ~RCX_SW_EXIT);
So, if this is the issue, then simply commenting out the tweaking of
RSTDBYCTL in ironlake_enable_rc6() should prevent the hang.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-02-01 16:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 11:22 Intel i915 freeze on latest git Francesco Allertsen
2011-02-01 12:05 ` Chris Wilson
2011-02-01 12:29 ` Francesco Allertsen
2011-02-01 13:16 ` Chris Wilson
2011-02-01 14:07 ` Francesco Allertsen
2011-02-01 16:31 ` Jesse Barnes
2011-02-01 16:57 ` Chris Wilson [this message]
2011-02-01 17:37 ` Jesse Barnes
2011-02-02 9:56 ` Francesco Allertsen
2011-02-02 9:59 ` Chris Wilson
2011-02-02 11:46 ` Francesco Allertsen
2011-02-09 12:52 ` Francesco Allertsen
2011-02-09 17:09 ` Chris Wilson
2011-02-09 17:50 ` Jesse Barnes
2011-02-09 17:53 ` Jesse Barnes
2011-02-09 17:59 ` Jesse Barnes
2011-02-09 18:06 ` Chris Wilson
2011-02-10 12:10 ` Francesco Allertsen
2011-02-10 18:34 ` Jesse Barnes
2011-02-10 23:23 ` Francesco Allertsen
2011-02-10 23:25 ` Jesse Barnes
2011-02-11 7:28 ` Francesco Allertsen
2011-02-11 17:16 ` Jesse Barnes
2011-02-12 3:14 ` Grissiom
2011-02-13 16:53 ` Francesco Allertsen
2011-02-01 13:00 ` Francesco Allertsen
2011-02-01 13:18 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b7da2f$qaam25@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=fallertsen@gmail.com \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox