From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B81DC001B0 for ; Tue, 15 Aug 2023 04:18:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C17FF10E147; Tue, 15 Aug 2023 04:18:19 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FC3B10E147 for ; Tue, 15 Aug 2023 04:18:18 +0000 (UTC) Received: from [192.168.2.208] (109-252-150-127.dynamic.spd-mgts.ru [109.252.150.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9D0876606F97; Tue, 15 Aug 2023 05:18:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1692073097; bh=FWknYi+x2YxXpMcEB9auJYkzI7jgt6eKgxUFNVg/1fw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KEVKWrjsmeilzRPKMez2JDZogGRJL+9oCAVUlXV1xCXsJjDz/AErWHm3NWY75A/Em jCclFmeAG7nuuyea5R+u72Pc6xOiQNnN0e+XUtIesQ7YoDaMO1tp3xpTF2EeaJCNdF WvZEyR4AaSZxxiGMtON2PcB78D1anEppZ0DfXgIBHHlIwhrJ6Ld0APo+Ax5QeHjweB v/t506fUmEI8XgcB7R+hfyEvTFu5f7pGBeHNPeohB7Iuj2Fyu75Ius8CgLfNEOmzAR WMwFE+Rh4Dyahl08/E08omRND7HEsJTZUz/BmzKfJcIUH6XPuznWez4i5A4ddDtlA1 AG7ibNXVfKE6Q== Message-ID: Date: Tue, 15 Aug 2023 07:18:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH 1/3] drm/virtio: .release ops for virtgpu fence release Content-Language: en-US To: Dongwon Kim , dri-devel@lists.freedesktop.org References: <20230712224424.30158-1-dongwon.kim@intel.com> <20230712224424.30158-2-dongwon.kim@intel.com> From: Dmitry Osipenko In-Reply-To: <20230712224424.30158-2-dongwon.kim@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vivek Kasireddy , kraxel@redhat.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/13/23 01:44, Dongwon Kim wrote: > virtio_gpu_fence_release is added to free virtio-gpu-fence > upon release of dma_fence. > > Cc: Gerd Hoffmann > Cc: Vivek Kasireddy > Signed-off-by: Dongwon Kim > --- > drivers/gpu/drm/virtio/virtgpu_fence.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_fence.c b/drivers/gpu/drm/virtio/virtgpu_fence.c > index f28357dbde35..ba659ac2a51d 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_fence.c > +++ b/drivers/gpu/drm/virtio/virtgpu_fence.c > @@ -63,12 +63,20 @@ static void virtio_gpu_timeline_value_str(struct dma_fence *f, char *str, > (u64)atomic64_read(&fence->drv->last_fence_id)); > } > > +static void virtio_gpu_fence_release(struct dma_fence *f) > +{ > + struct virtio_gpu_fence *fence = to_virtio_gpu_fence(f); > + > + kfree(fence); > +} > + > static const struct dma_fence_ops virtio_gpu_fence_ops = { > .get_driver_name = virtio_gpu_get_driver_name, > .get_timeline_name = virtio_gpu_get_timeline_name, > .signaled = virtio_gpu_fence_signaled, > .fence_value_str = virtio_gpu_fence_value_str, > .timeline_value_str = virtio_gpu_timeline_value_str, > + .release = virtio_gpu_fence_release, > }; > > struct virtio_gpu_fence *virtio_gpu_fence_alloc(struct virtio_gpu_device *vgdev, This change doesn't do anything practically useful, AFAICT. -- Best regards, Dmitry