From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "Harrison, John C" <john.c.harrison@intel.com>,
"Intel-GFX@Lists.FreeDesktop.Org"
<Intel-GFX@Lists.FreeDesktop.Org>
Cc: "DRI-Devel@Lists.FreeDesktop.Org" <DRI-Devel@Lists.FreeDesktop.Org>
Subject: Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/guc: Capture list naming clean up
Date: Wed, 3 May 2023 17:54:25 +0000 [thread overview]
Message-ID: <b8fa0992331f215fe8df08660dcca525cf703612.camel@intel.com> (raw)
In-Reply-To: <20230428185636.457407-4-John.C.Harrison@Intel.com>
LGTM:
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
On Fri, 2023-04-28 at 11:56 -0700, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Don't use 'xe_lp*' prefixes for register lists that are common with
> Gen8.
>
> Don't add Xe only GSC registers to pre-Xe devices that don't
> even have a GSC engine.
>
> Fix Xe_LP name.
>
> Don't use GEN9 as a prefix for register lists that contain all GEN8
> registers.
>
> Rename the 'default_' register list prefix to 'gen8_' as that is the
> more accurate name.
alan:snip
next prev parent reply other threads:[~2023-05-03 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 18:56 [PATCH v2 0/4] Improvements to GuC error capture John.C.Harrison
2023-04-28 18:56 ` [PATCH v2 1/4] drm/i915/guc: Don't capture Gen8 regs on Xe devices John.C.Harrison
2023-04-28 18:56 ` [PATCH v2 2/4] drm/i915/guc: Consolidate duplicated capture list code John.C.Harrison
2023-04-28 18:56 ` [PATCH v2 3/4] drm/i915/guc: Capture list naming clean up John.C.Harrison
2023-05-03 17:54 ` Teres Alexis, Alan Previn [this message]
2023-04-28 18:56 ` [PATCH v2 4/4] drm/i915/guc: Fix error capture for virtual engines John.C.Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8fa0992331f215fe8df08660dcca525cf703612.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=DRI-Devel@Lists.FreeDesktop.Org \
--cc=Intel-GFX@Lists.FreeDesktop.Org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox