From: Chris Wilson <chris@chris-wilson.co.uk>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm: Only evict the blocks required to create the requested hole
Date: Tue, 18 Dec 2012 10:37:06 +0000 [thread overview]
Message-ID: <b94cdc$7rduot@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1355680301-25749-1-git-send-email-chris@chris-wilson.co.uk>
On Sun, 16 Dec 2012 17:51:41 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Avoid clobbering adjacent blocks if they happen to expire earlier and
> amalgamate together to form the requested hole.
>
> In passing this fixes a regression from
> commit ea7b1dd44867e9cd6bac67e7c9fc3f128b5b255c
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Fri Feb 18 17:59:12 2011 +0100
>
> drm: mm: track free areas implicitly
>
> which swaps the end address for size (with a potential overflow) and
> effectively causes the eviction code to clobber almost all earlier
> buffers above the evictee.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
On IRC I mentioned that I feared there be dragon lurking here. They
turned out to be figments of my own code - a later patch to adjust the
allocation of nodes was incomplete.
Please review and consider this patch.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-18 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 17:51 [PATCH] drm: Only evict the blocks required to create the requested hole Chris Wilson
2012-12-18 10:37 ` Chris Wilson [this message]
2012-12-19 16:05 ` Chris Wilson
2012-12-19 16:51 ` Chris Wilson
2013-01-07 20:55 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$7rduot@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox