From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] i915: restore only the mode of this driver on lastclose
Date: Mon, 11 Apr 2011 08:21:02 +0100 [thread overview]
Message-ID: <b9dded$ilhjcs@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1302499397-11051-1-git-send-email-airlied@gmail.com>
On Mon, 11 Apr 2011 15:23:17 +1000, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This has always used a big hammer, but that hammer is probably
> too big, I'm also not sure its necessary but at least this
> should be safe.
So the difference appears to be that the patch only restores the fbcon
of a device for the lastclose of that device. That makes sense.
However, would it not be better to make this a generic
drm_fb_helper_restore_mode() as it sounds like something every driver
should consider?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-11 7:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 5:23 [PATCH] i915: restore only the mode of this driver on lastclose Dave Airlie
2011-04-11 7:21 ` Chris Wilson [this message]
2011-04-11 16:06 ` Keith Packard
2011-04-11 17:31 ` Chris Wilson
2011-04-11 17:55 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$ilhjcs@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox