From: "Thomas Hellström (Intel)" <thomas_os@shipmail.org>
To: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v7 15/15] drm/i915: Use ttm mmap handling for ttm bo's.
Date: Mon, 31 May 2021 19:17:34 +0200 [thread overview]
Message-ID: <bbef47d0-e465-9cab-a68f-818431fca868@shipmail.org> (raw)
In-Reply-To: <20210531121940.267032-16-thomas.hellstrom@linux.intel.com>
On 5/31/21 2:19 PM, Thomas Hellström wrote:
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> Use the ttm handlers for servicing page faults, and vm_access.
>
> We do our own validation of read-only access, otherwise use the
> ttm handlers as much as possible.
>
> Because the ttm handlers expect the vma_node at vma->base, we slightly
> need to massage the mmap handlers to look at vma_node->driver_private
> to fetch the bo, if it's NULL, we assume i915's normal mmap_offset uapi
> is used.
>
> This is the easiest way to achieve compatibility without changing ttm's
> semantics.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
prev parent reply other threads:[~2021-05-31 17:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 12:19 [PATCH v7 00/15] Move LMEM (VRAM) management over to TTM Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 01/15] drm/i915: Untangle the vma pages_mutex Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 02/15] drm/i915: Don't free shared locks while shared Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 03/15] drm/i915: Fix i915_sg_page_sizes to record dma segments rather than physical pages Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 04/15] drm/i915/ttm Initialize the ttm device and memory managers Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 05/15] drm/i915/ttm: Embed a ttm buffer object in the i915 gem object Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 06/15] drm/ttm: Add a generic TTM memcpy move for page-based iomem Thomas Hellström
2021-05-31 12:36 ` Christian König
2021-05-31 13:08 ` Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 07/15] drm: Add a prefetching memcpy_from_wc Thomas Hellström
2021-05-31 12:37 ` Christian König
2021-05-31 12:19 ` [PATCH v7 08/15] drm/ttm: Use drm_memcpy_from_wc for TTM bo moves Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 09/15] drm/ttm: Document and optimize ttm_bo_pipeline_gutting() Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 10/15] drm/ttm, drm/amdgpu: Allow the driver some control over swapping Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 11/15] drm/i915/ttm: Introduce a TTM i915 gem object backend Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 12/15] drm/i915/lmem: Verify checks for lmem residency Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 13/15] drm/i915: Disable mmap ioctl for gen12+ Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 14/15] drm/vma: Add a driver_private member to vma_node Thomas Hellström
2021-05-31 12:19 ` [PATCH v7 15/15] drm/i915: Use ttm mmap handling for ttm bo's Thomas Hellström
2021-05-31 17:17 ` Thomas Hellström (Intel) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbef47d0-e465-9cab-a68f-818431fca868@shipmail.org \
--to=thomas_os@shipmail.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox