From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD1EC4338F for ; Mon, 16 Aug 2021 07:42:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAB6061ACE for ; Mon, 16 Aug 2021 07:42:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EAB6061ACE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F21AA89CA2; Mon, 16 Aug 2021 07:42:50 +0000 (UTC) Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB6C189CA2 for ; Mon, 16 Aug 2021 07:42:48 +0000 (UTC) Subject: Re: [PATCH] drm/fb: Fix randconfig builds DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1629099766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CBPbvbO8jMkNdtM0Jgwi68KHAmvkiVFmnKhgdYN2A30=; b=XJLGOJ2J1nGW6rslCizdvgJQxTjQ3UKh69REq6RhTJFcMDZxB0VPe7U7pyeFM4WabvvMbm U41trbVejgnWO7ajE6WafJNttc871TsJiv5fDXLkjpQJzsm06a9Um9JhUgULIUQQ05DtLE rgOsDNBRs5aUNdR7VZFHovHMeKzc3cA= To: Jani Nikula , daniel@ffwll.ch, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, liuyun01@kylinos.cn References: <20210816064835.332785-1-liu.yun@linux.dev> <87y291kh4c.fsf@intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jackie Liu Message-ID: Date: Mon, 16 Aug 2021 15:42:40 +0800 MIME-Version: 1.0 In-Reply-To: <87y291kh4c.fsf@intel.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: liu.yun@linux.dev X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" After commit f611b1e7624c, we change select FB to depends on FB. How about this£º diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 7ff89690a976..cd129d96e649 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - depends on FB + depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA -- Jackie Liu ÔÚ 2021/8/16 ÏÂÎç3:01, Jani Nikula дµÀ: > On Mon, 16 Aug 2021, Jackie Liu wrote: >> From: Jackie Liu >> >> When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the >> compilation will fail. we need make that dependency explicit. > > What's the failure mode? Using select here is a bad idea. > > BR, > Jani. > >> >> Reported-by: k2ci >> Signed-off-by: Jackie Liu >> --- >> drivers/gpu/drm/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig >> index 7ff89690a976..346a518b5119 100644 >> --- a/drivers/gpu/drm/Kconfig >> +++ b/drivers/gpu/drm/Kconfig >> @@ -98,7 +98,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS >> config DRM_FBDEV_EMULATION >> bool "Enable legacy fbdev support for your modesetting driver" >> depends on DRM >> - depends on FB >> + select FB >> select DRM_KMS_HELPER >> select FB_CFB_FILLRECT >> select FB_CFB_COPYAREA >