From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 520CAC369D5 for ; Mon, 28 Apr 2025 20:24:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8BF510EA0E; Mon, 28 Apr 2025 20:24:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="JrY6z5Ew"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEA6B10EA0E for ; Mon, 28 Apr 2025 20:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745871838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rkEtrqEhBS4XY4MnxLuPuVZCrKNUqZ8c+beG4mFgbns=; b=JrY6z5EwOIR79+F7ECFoCL5Ys2UOR/E0t11a04ZyZKXQPo8Mn2NQY27pDnFw70+HbTksVa sePT3LaplT1UM7bPFHYXA5mpfqBQ33Y676ekmkf1CPX6iTW1+PpovJhfl2jVmd2CWPwaLF f3gmmcn0bMzJgc7CpMwTh/0gMSNDcok= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-BxiPx7tcONWNGTTX2l2-xA-1; Mon, 28 Apr 2025 16:23:56 -0400 X-MC-Unique: BxiPx7tcONWNGTTX2l2-xA-1 X-Mimecast-MFC-AGG-ID: BxiPx7tcONWNGTTX2l2-xA_1745871835 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3912d5f6689so2799202f8f.1 for ; Mon, 28 Apr 2025 13:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745871825; x=1746476625; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rkEtrqEhBS4XY4MnxLuPuVZCrKNUqZ8c+beG4mFgbns=; b=P5FA206BKtdwIsKnSBfiXRCNmwknAPeny4vquk6ldrvma/DGTbGTpUK3BgP/kSX3EB mRR84iurqTlM56BEXPCSNsjHNT7vuu0mZI82kHW5IcRA/aAbx6s71xT0Lf1APgHMdj4t jw0xam2o0e6WveUTKz6zkO1KxmRl3egXSCSPr8UpKRjzEkakzxMenIEDawDHrXSjBhLK uqkeMAOxdn7XA8CY9/hmZM5coxRnIJ3hnQxu69j0yFPmYcQL1DwPyoyA9kK+3y4ohHAk GcT5HYbeSKQryIM9n3wyvU6RSi9eMv4bBUJqzcf3g6Q/0vSz6sDH/jfsVcp9pPESOwLq xl6A== X-Forwarded-Encrypted: i=1; AJvYcCUZS+dDkUEw8mQR+9BVuZqaWZI0D90VCnQwsi+sx6BxQ5CYuRVmi7o0cyt3bZQELxEUi1SV0a8l8uw=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzuVDkT5c+NwnsWyE5p7EsmQE/OB7aNn5GdN1Ba5S7WIyQvlyl4 diexMd2JF2gg4lntelsbZXCozaUkdXDnJCs7R7ImI25RiH47E/EgymCEL6vq/tReIlc8mmjM55/ /pvk9gC5tYBXD7qACr1LRGFeGP3XoDpWZDyAjpHjIZk9+YcYNRkSbTm6bMYGygk08+w== X-Gm-Gg: ASbGncvvrUmv4L3lSdIJZtVSo7WlALrNWBWVXO9yaTPFnDT0sR4Nfp0NmwYpctvIeP0 Y2USQBlvVMA6fnP/ktZ1UqRu5G5dBIh90h7FeQo9B61BJELYT7NGIMDlco85j0x9GhW+iiSod8t wJW0Njcddy9uXpsLPstTqi5MUD9g/MzkwRqmvLTRUPokJKFMXHp6oZz8Kr9iI4RcKLNqSpBrI2+ 09AQ01QQUflZKT/xSBr62JQ9crD719csctEuJFNd1oZofkr53B7YHhXqHrSDUURjjqBpguEQboC jIJR0Jm6SvFGB3W2xXAZ/oySPsPMNgVnwjyrjD4deoaSjwfusMU7mkensmSPVEFJ83kc01LKMD0 IgsydAbz2vv++k5UqFIc8xsMTnBirP4J+OMi4438= X-Received: by 2002:a05:6000:b4e:b0:39e:cc5e:147 with SMTP id ffacd0b85a97d-3a0894a1aa8mr941306f8f.55.1745871825198; Mon, 28 Apr 2025 13:23:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHi9BeKEw90HGojYH0uYj++rRWoQl9Ep0UCTEuLPP1j3Ci9jqWDeYDWhMBAhQ1IJFvMvOz7CA== X-Received: by 2002:a05:6000:b4e:b0:39e:cc5e:147 with SMTP id ffacd0b85a97d-3a0894a1aa8mr941276f8f.55.1745871824797; Mon, 28 Apr 2025 13:23:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073cbf04dsm12236556f8f.52.2025.04.28.13.23.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 13:23:44 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 22:23:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 05/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack() To: Suren Baghdasaryan , Lorenzo Stoakes Cc: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-6-david@redhat.com> <7a26e29c-d889-450a-a5e1-ce671f09e4c8@redhat.com> <884fab29-e16a-4663-8e33-885bc70ca2f7@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: U7wUheaUtZNWoEzn2NUMtryov85kDuzZ6qL1SQMb_GE_1745871835 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28.04.25 21:57, Suren Baghdasaryan wrote: > On Mon, Apr 28, 2025 at 12:37 PM Lorenzo Stoakes > wrote: >> >> On Mon, Apr 28, 2025 at 07:23:18PM +0200, David Hildenbrand wrote: >>> On 28.04.25 18:24, Peter Xu wrote: >>>> On Mon, Apr 28, 2025 at 06:16:21PM +0200, David Hildenbrand wrote: >>>>>> Probably due to what config you have. E.g., when I'm looking mine it's >>>>>> much bigger and already consuming 256B, but it's because I enabled more >>>>>> things (userfaultfd, lockdep, etc.). >>>>> >>>>> Note that I enabled everything that you would expect on a production system >>>>> (incld. userfaultfd, mempolicy, per-vma locks), so I didn't enable lockep. >>>> >>>> I still doubt whether you at least enabled userfaultfd, e.g., your previous >>>> paste has: >>>> >>>> struct vm_userfaultfd_ctx vm_userfaultfd_ctx; /* 176 0 */ >>>> >>>> Not something that matters.. but just in case you didn't use the expected >>>> config file you wanted to use.. >>> >>> You're absolutely right. I only briefly rechecked for this purpose here on >>> my notebook, and only looked for the existence of members, not expecting >>> that we have confusing stuff like vm_userfaultfd_ctx. >>> >>> I checked again and the size stays at 192 with allyesconfig and then >>> disabling debug options. >> >> I think a reasonable case is everything on, except CONFIG_DEBUG_LOCK_ALLOC and I >> don't care about nommu. > > I think it's safe to assume that production systems would disable > lockdep due to the performance overhead. At least that's what we do on > Android - enable it on development branches but disable in production. Right, and "struct lockdep_map" is ... significantly larger than 8 bytes. With that enabled, one is already paying for extra VMA space ... -- Cheers, David / dhildenb