From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58E4BC2BD09 for ; Mon, 1 Jul 2024 09:03:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE3DD10E377; Mon, 1 Jul 2024 09:03:13 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 356E010E378 for ; Mon, 1 Jul 2024 09:03:12 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9B8C3339; Mon, 1 Jul 2024 02:03:36 -0700 (PDT) Received: from [10.57.44.170] (unknown [10.57.44.170]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DFE53F766; Mon, 1 Jul 2024 02:03:10 -0700 (PDT) Message-ID: Date: Mon, 1 Jul 2024 10:03:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/panthor: Don't check the array stride on empty uobj arrays To: Boris Brezillon , Liviu Dudau , =?UTF-8?Q?Adri=C3=A1n_Larumbe?= Cc: dri-devel@lists.freedesktop.org, kernel@collabora.com References: <20240628145536.778349-1-boris.brezillon@collabora.com> <20240628145536.778349-2-boris.brezillon@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20240628145536.778349-2-boris.brezillon@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28/06/2024 15:55, Boris Brezillon wrote: > The user is likely to leave all the drm_panthor_obj_array fields > to zero when the array is empty, which will cause an EINVAL failure. > > Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block") > Signed-off-by: Boris Brezillon Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_drv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c > index b8a84f26b3ef..b5e7b919f241 100644 > --- a/drivers/gpu/drm/panthor/panthor_drv.c > +++ b/drivers/gpu/drm/panthor/panthor_drv.c > @@ -86,15 +86,15 @@ panthor_get_uobj_array(const struct drm_panthor_obj_array *in, u32 min_stride, > int ret = 0; > void *out_alloc; > > + if (!in->count) > + return NULL; > + > /* User stride must be at least the minimum object size, otherwise it might > * lack useful information. > */ > if (in->stride < min_stride) > return ERR_PTR(-EINVAL); > > - if (!in->count) > - return NULL; > - > out_alloc = kvmalloc_array(in->count, obj_size, GFP_KERNEL); > if (!out_alloc) > return ERR_PTR(-ENOMEM);