* [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline
@ 2025-10-29 19:42 Marek Vasut
2025-10-29 22:07 ` Rob Herring (Arm)
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marek Vasut @ 2025-10-29 19:42 UTC (permalink / raw)
To: devicetree
Cc: Marek Vasut, Conor Dooley, David Airlie, Frank Binns,
Krzysztof Kozlowski, Maarten Lankhorst, Matt Coster,
Maxime Ripard, Rob Herring, Simona Vetter, Thomas Zimmermann,
dri-devel, linux-kernel
Fix the following DT schema check warning:
./Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml:103:1: [warning] too many blank lines (2 > 1) (empty-lines)
One newline is enough. No functional change.
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Frank Binns <frank.binns@imgtec.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Matt Coster <matt.coster@imgtec.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
index aa8b2069cc24b..a7ca6d3fdf10a 100644
--- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
+++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
@@ -100,7 +100,6 @@ allOf:
clocks:
maxItems: 1
-
- if:
properties:
compatible:
--
2.51.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline
2025-10-29 19:42 [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline Marek Vasut
@ 2025-10-29 22:07 ` Rob Herring (Arm)
2025-10-30 12:08 ` Matt Coster
2025-10-31 14:42 ` Matt Coster
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2025-10-29 22:07 UTC (permalink / raw)
To: Marek Vasut
Cc: Maarten Lankhorst, Simona Vetter, devicetree, dri-devel,
David Airlie, Conor Dooley, Thomas Zimmermann,
Krzysztof Kozlowski, Maxime Ripard, linux-kernel, Matt Coster,
Frank Binns
On Wed, 29 Oct 2025 20:42:02 +0100, Marek Vasut wrote:
> Fix the following DT schema check warning:
>
> ./Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml:103:1: [warning] too many blank lines (2 > 1) (empty-lines)
>
> One newline is enough. No functional change.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Frank Binns <frank.binns@imgtec.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Matt Coster <matt.coster@imgtec.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> ---
> Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline
2025-10-29 19:42 [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline Marek Vasut
2025-10-29 22:07 ` Rob Herring (Arm)
@ 2025-10-30 12:08 ` Matt Coster
2025-10-30 13:51 ` Marek Vasut
2025-10-31 14:42 ` Matt Coster
2 siblings, 1 reply; 5+ messages in thread
From: Matt Coster @ 2025-10-30 12:08 UTC (permalink / raw)
To: Marek Vasut
Cc: Conor Dooley, David Airlie, Frank Binns, Alessio Belle,
Alexandru Dadu, Krzysztof Kozlowski, Maarten Lankhorst,
Maxime Ripard, Rob Herring, Simona Vetter, Thomas Zimmermann,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
[-- Attachment #1.1: Type: text/plain, Size: 1876 bytes --]
Hi Marek,
On 29/10/2025 19:42, Marek Vasut wrote:
> Fix the following DT schema check warning:
>
> ./Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml:103:1: [warning] too many blank lines (2 > 1) (empty-lines)
>
> One newline is enough. No functional change.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Good catch! Thanks for sending a fix. Does this also need:
Fixes: 18ff1dc462ef ("dt-bindings: gpu: img,powervr-rogue: Document GX6250 GPU in Renesas R-Car M3-W/M3-W+")
Either way:
Reviewed-by: Matt Coster <matt.coster@imgtec.com>
And I'll apply to drm-misc-next (or -fixes with the tag) later today.
Cheers,
Matt
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Frank Binns <frank.binns@imgtec.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Matt Coster <matt.coster@imgtec.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> ---
> Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index aa8b2069cc24b..a7ca6d3fdf10a 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -100,7 +100,6 @@ allOf:
> clocks:
> maxItems: 1
>
> -
> - if:
> properties:
> compatible:
--
Matt Coster
E: matt.coster@imgtec.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline
2025-10-30 12:08 ` Matt Coster
@ 2025-10-30 13:51 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2025-10-30 13:51 UTC (permalink / raw)
To: Matt Coster
Cc: Conor Dooley, David Airlie, Frank Binns, Alessio Belle,
Alexandru Dadu, Krzysztof Kozlowski, Maarten Lankhorst,
Maxime Ripard, Rob Herring, Simona Vetter, Thomas Zimmermann,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
On 10/30/25 1:08 PM, Matt Coster wrote:
Hello Matt,
> On 29/10/2025 19:42, Marek Vasut wrote:
>> Fix the following DT schema check warning:
>>
>> ./Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml:103:1: [warning] too many blank lines (2 > 1) (empty-lines)
>>
>> One newline is enough. No functional change.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>
> Good catch! Thanks for sending a fix. Does this also need:
Got a hint from Rob how to better scan bindings before sending patches,
so the credit really goes there.
> Fixes: 18ff1dc462ef ("dt-bindings: gpu: img,powervr-rogue: Document GX6250 GPU in Renesas R-Car M3-W/M3-W+")
I am not sure about this one, I would say no because it has no
functional impact on the kernel and/or does not fix any functional bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline
2025-10-29 19:42 [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline Marek Vasut
2025-10-29 22:07 ` Rob Herring (Arm)
2025-10-30 12:08 ` Matt Coster
@ 2025-10-31 14:42 ` Matt Coster
2 siblings, 0 replies; 5+ messages in thread
From: Matt Coster @ 2025-10-31 14:42 UTC (permalink / raw)
To: devicetree, Marek Vasut
Cc: Conor Dooley, David Airlie, Frank Binns, Krzysztof Kozlowski,
Maarten Lankhorst, Maxime Ripard, Rob Herring, Simona Vetter,
Thomas Zimmermann, dri-devel, linux-kernel
On Wed, 29 Oct 2025 20:42:02 +0100, Marek Vasut wrote:
> Fix the following DT schema check warning:
>
> ./Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml:103:1: [warning] too many blank lines (2 > 1) (empty-lines)
>
> One newline is enough. No functional change.
>
>
> [...]
Applied, thanks!
[1/1] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline
commit: 75d42e0351ac5ea080c33a15a92293155f51c9c9
Best regards,
--
Matt Coster <matt.coster@imgtec.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-10-31 14:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-29 19:42 [PATCH] dt-bindings: gpu: img,powervr-rogue: Drop duplicate newline Marek Vasut
2025-10-29 22:07 ` Rob Herring (Arm)
2025-10-30 12:08 ` Matt Coster
2025-10-30 13:51 ` Marek Vasut
2025-10-31 14:42 ` Matt Coster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).