From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 100089] [regression] [bisected] Space Run rendering issues Date: Thu, 16 Mar 2017 15:25:11 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1000455716==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 581216EB23 for ; Thu, 16 Mar 2017 15:25:11 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1000455716== Content-Type: multipart/alternative; boundary="14896779111.62E39.6216"; charset="UTF-8" --14896779111.62E39.6216 Date: Thu, 16 Mar 2017 15:25:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D100089 Samuel Pitoiset changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Space Run rendering prolems |[regression] [bisected] | |Space Run rendering issues --- Comment #9 from Samuel Pitoiset --- After bisecting, the guilty is: commit 3081264dbeb5c322456b1b6b9011745ab98982a1 Author: Stanislav Mekhanoshin Date: Sat Mar 11 00:29:27 2017 +0000 [AMDGPU] Remove getBidirectionalReasonRank This method inverts the Reason field of a scheduling candidate. It does right comparison between RegCritical and RegExcess, but everything else is broken. In fact it can prefer less strong reason such as Weak over RegCritical because Weak > -RegCritical. The CandReason enum is properly sorted, so just remove artificial ranking. Differential Revision: https://reviews.llvm.org/D30557 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@297536 91177308-0d34-0410-b5e6-96231b3b80d8 Presumably, it's a scheduling issue. The commit looks correct though. --=20 You are receiving this mail because: You are the assignee for the bug.= --14896779111.62E39.6216 Date: Thu, 16 Mar 2017 15:25:11 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Samuel Pitoiset changed bug 10008= 9
What Removed Added
Summary Space Run rendering prolems [regression] [bisected] Space Run rendering issues

Commen= t # 9 on bug 10008= 9 from Samuel Pitoiset
After bisecting, the guilty is:

commit 3081264dbeb5c322456b1b6b9011745ab98982a1
Author: Stanislav Mekhanoshin <Stanislav.Mekhanoshin@amd.com>
Date:   Sat Mar 11 00:29:27 2017 +0000

    [AMDGPU] Remove getBidirectionalReasonRank

    This method inverts the Reason field of a scheduling candidate.
    It does right comparison between RegCritical and RegExcess, but
    everything else is broken. In fact it can prefer less strong reason
    such as Weak over RegCritical because Weak > -RegCritical.

    The CandReason enum is properly sorted, so just remove artificial
    ranking.

    Differential Revision: http=
s://reviews.llvm.org/D30557

    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@297536
91177308-0d34-0410-b5e6-96231b3b80d8

Presumably, it's a scheduling issue. The commit looks correct though.


You are receiving this mail because:
  • You are the assignee for the bug.
= --14896779111.62E39.6216-- --===============1000455716== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1000455716==--