* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
@ 2017-03-07 18:36 ` bugzilla-daemon
2017-03-15 13:39 ` bugzilla-daemon
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2017-03-07 18:36 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 729 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
Vedran Miletić <vedran@miletic.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |99553
URL| |http://deeplearning.net/sof
| |tware/libgpuarray/installat
| |ion.html
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=99553
[Bug 99553] Tracker bug for runnning OpenCL applications on Clover
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1820 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
2017-03-07 18:36 ` bugzilla-daemon
@ 2017-03-15 13:39 ` bugzilla-daemon
2017-03-22 14:08 ` bugzilla-daemon
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2017-03-15 13:39 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 528 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
Vedran Miletić <vedran@miletic.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |100212
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=100212
[Bug 100212] Implement vload_* and vstore_* to make Theano/libgpuarray working
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1610 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
2017-03-07 18:36 ` bugzilla-daemon
2017-03-15 13:39 ` bugzilla-daemon
@ 2017-03-22 14:08 ` bugzilla-daemon
2017-09-18 22:55 ` bugzilla-daemon
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2017-03-22 14:08 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 519 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
Vedran Miletić <vedran@miletic.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |94273
Referenced Bugs:
https://bugs.freedesktop.org/show_bug.cgi?id=94273
[Bug 94273] Clover on RadeonSI OpenCL segfault during testing of clBLAS
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1595 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (2 preceding siblings ...)
2017-03-22 14:08 ` bugzilla-daemon
@ 2017-09-18 22:55 ` bugzilla-daemon
2018-02-06 18:54 ` bugzilla-daemon
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2017-09-18 22:55 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1831 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
--- Comment #1 from Jan Vesely <jan.vesely@rutgers.edu> ---
*** Testing for AMD Radeon R7 Graphics (CARRIZO / DRM 3.18.0 / 4.11.0-ROC, LLVM
5.0.0)
Ran 6670 tests in 785.274s
FAILED (SKIP=12, errors=580, failures=12)
all errors are caused by:
TypeError: This is for CUDA arrays.
I haven't investigated the failures.
There are couple of patches needed:
https://github.com/Theano/libgpuarray/pull/534
https://github.com/Theano/libgpuarray/pull/535
http://lists.llvm.org/pipermail/libclc-dev/2017-September/002449.html
and:
diff --git a/src/cluda_opencl.h b/src/cluda_opencl.h
index 6e0095c..e93aa8b 100644
--- a/src/cluda_opencl.h
+++ b/src/cluda_opencl.h
@@ -48,9 +48,9 @@ typedef struct _ga_half {
} ga_half;
#define ga_half2float(p) vload_half(0, &((p).data))
-static inline ga_half ga_float2half(ga_float f) {
+inline ga_half ga_float2half(ga_float f) {
ga_half r;
- vstore_half_rtn(f, 0, &r.data);
+ vstore_half(f, 0, &r.data);
return r;
}
diff --git a/src/gpuarray_buffer_opencl.c b/src/gpuarray_buffer_opencl.c
index 8f12811..2041ca2 100644
--- a/src/gpuarray_buffer_opencl.c
+++ b/src/gpuarray_buffer_opencl.c
@@ -146,7 +146,7 @@ cl_ctx *cl_make_ctx(cl_context ctx, gpucontext_props *p) {
CL_CHECKN(global_err, clGetDeviceInfo(id, CL_DEVICE_VERSION,
device_version_size,
device_version, NULL));
- if (device_version[7] == '1' && device_version[9] < '2') {
+ if (device_version[7] == '1' && device_version[9] < '1') {
error_set(global_err, GA_UNSUPPORTED_ERROR,
"We only support OpenCL 1.2 and up");
return NULL;
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2907 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (3 preceding siblings ...)
2017-09-18 22:55 ` bugzilla-daemon
@ 2018-02-06 18:54 ` bugzilla-daemon
2018-04-04 23:37 ` bugzilla-daemon
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-02-06 18:54 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
Bug 100105 depends on bug 100212, which changed state.
Bug 100212 Summary: Implement vload_* and vstore_* to make Theano/libgpuarray working
https://bugs.freedesktop.org/show_bug.cgi?id=100212
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1341 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (4 preceding siblings ...)
2018-02-06 18:54 ` bugzilla-daemon
@ 2018-04-04 23:37 ` bugzilla-daemon
2018-04-04 23:52 ` bugzilla-daemon
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-04-04 23:37 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2626 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
--- Comment #2 from Jan Vesely <jan.vesely@rutgers.edu> ---
Latest update:
diff --git a/src/cluda_opencl.h b/src/cluda_opencl.h
index 6e0095c..8ba2d14 100644
--- a/src/cluda_opencl.h
+++ b/src/cluda_opencl.h
@@ -48,7 +48,7 @@ typedef struct _ga_half {
} ga_half;
#define ga_half2float(p) vload_half(0, &((p).data))
-static inline ga_half ga_float2half(ga_float f) {
+inline ga_half ga_float2half(ga_float f) {
ga_half r;
vstore_half_rtn(f, 0, &r.data);
return r;
diff --git a/src/gpuarray_buffer_opencl.c b/src/gpuarray_buffer_opencl.c
index 8f12811..2041ca2 100644
--- a/src/gpuarray_buffer_opencl.c
+++ b/src/gpuarray_buffer_opencl.c
@@ -146,7 +146,7 @@ cl_ctx *cl_make_ctx(cl_context ctx, gpucontext_props *p) {
CL_CHECKN(global_err, clGetDeviceInfo(id, CL_DEVICE_VERSION,
device_version_size,
device_version, NULL));
- if (device_version[7] == '1' && device_version[9] < '2') {
+ if (device_version[7] == '1' && device_version[9] < '1') {
error_set(global_err, GA_UNSUPPORTED_ERROR,
"We only support OpenCL 1.2 and up");
return NULL
>>> pygpu.test()
pygpu is installed in
/home/jvesely/.local/lib/python3.6/site-packages/pygpu-0.7.5+12.g6f0132c.dirty-py3.6-linux-x86_64.egg/pygpu
NumPy version 1.13.3
NumPy relaxed strides checking option: True
NumPy is installed in /usr/lib64/python3.6/site-packages/numpy
Python version 3.6.4 (default, Mar 13 2018, 18:18:20) [GCC 7.3.1 20180303 (Red
Hat 7.3.1-5)]
nose version 1.3.7
*** Testing for AMD Radeon R7 Graphics (CARRIZO / DRM 3.23.0 /
4.15.14-300.fc27.x86_64, LLVM 6.0.0)
----------------------------------------------------------------------
Ran 6670 tests in 995.728s
FAILED (SKIP=12, errors=580, failures=2)
All errors are: TypeError: This is for CUDA arrays.
The two failures are:
FAIL: pygpu.tests.test_elemwise.test_elemwise_f16(<built-in function add>,
'float16', 'float16', (50,))
FAIL: pygpu.tests.test_elemwise.test_elemwise_f16(<built-in function iadd>,
'float16', 'float16', (50,))
Which fail on half precision rounding error. for example:
7.0390625+7.20703125 is expected to be 14.25 but gpu returns 14.2421875
the fp32 result is 14.24609375.
The GPU result is rounded down (towards zero)
The CPU result is rounded up (away from zero)
It looks like our vstore_half_rtn is not working as expected, which is weird
because it passes CTS.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 3541 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (5 preceding siblings ...)
2018-04-04 23:37 ` bugzilla-daemon
@ 2018-04-04 23:52 ` bugzilla-daemon
2018-04-04 23:56 ` bugzilla-daemon
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-04-04 23:52 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 652 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
--- Comment #3 from Jan Vesely <jan.vesely@rutgers.edu> ---
(In reply to Jan Vesely from comment #2)
> It looks like our vstore_half_rtn is not working as expected, which is weird
> because it passes CTS.
I take this back.
vstore_half_rtn rounds to negative infinity (towards 0 for positive numbers).
Changing line 53 in cluda_opencl.h:
- vstore_half_rtn(f, 0, &r.data);
+ vstore_half_rte(f, 0, &r.data);
fixes the two failures.
Other than advertising OCL1.2 the remaining failures are NOTOURBUG.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1528 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (6 preceding siblings ...)
2018-04-04 23:52 ` bugzilla-daemon
@ 2018-04-04 23:56 ` bugzilla-daemon
2018-04-04 23:56 ` bugzilla-daemon
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-04-04 23:56 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
Jan Vesely <jan.vesely@rutgers.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://github.com/Theano/l
| |ibgpuarray/issues/491
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1130 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (7 preceding siblings ...)
2018-04-04 23:56 ` bugzilla-daemon
@ 2018-04-04 23:56 ` bugzilla-daemon
2018-04-05 19:18 ` bugzilla-daemon
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-04-04 23:56 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 465 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
Jan Vesely <jan.vesely@rutgers.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://github.com/Theano/l
| |ibgpuarray/issues/462
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1130 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (8 preceding siblings ...)
2018-04-04 23:56 ` bugzilla-daemon
@ 2018-04-05 19:18 ` bugzilla-daemon
2018-04-23 20:20 ` bugzilla-daemon
2018-09-09 22:46 ` bugzilla-daemon
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-04-05 19:18 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
--- Comment #4 from Jan Vesely <jan.vesely@rutgers.edu> ---
Lowering CL requirements combined with the following pull requests:
https://github.com/Theano/libgpuarray/pull/571
https://github.com/Theano/libgpuarray/pull/570
Results in:
Ran 4970 tests in 1158.909s
OK (SKIP=12)
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1335 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (9 preceding siblings ...)
2018-04-05 19:18 ` bugzilla-daemon
@ 2018-04-23 20:20 ` bugzilla-daemon
2018-09-09 22:46 ` bugzilla-daemon
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-04-23 20:20 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 623 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
--- Comment #5 from Jan Vesely <jan.vesely@rutgers.edu> ---
(In reply to Jan Vesely from comment #4)
> Lowering CL requirements combined with the following pull requests:
> https://github.com/Theano/libgpuarray/pull/571
> https://github.com/Theano/libgpuarray/pull/570
Both above pull requests have been merged with slight modifications. running
CLOVER_DEVICE_VERSION_OVERRIDE=1.2 CLOVER_DEVICE_CLC_VERSION_OVERRIDE=1.2
results in:
Ran 6670 tests in 991.622s
OK (SKIP=12)
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1616 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
2017-03-07 18:35 [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI bugzilla-daemon
` (10 preceding siblings ...)
2018-04-23 20:20 ` bugzilla-daemon
@ 2018-09-09 22:46 ` bugzilla-daemon
11 siblings, 0 replies; 13+ messages in thread
From: bugzilla-daemon @ 2018-09-09 22:46 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=100105
Timothy Arceri <t_arceri@yahoo.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Drivers/Gallium/radeonsi |Gallium/StateTracker/Clover
Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
|.org |org
QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
|.org |org
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1575 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread