From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 100105] Make Theano OpenCL support work on Clover and RadeonSI
Date: Mon, 18 Sep 2017 22:55:21 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1391466027=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 37D866E489
for ; Mon, 18 Sep 2017 22:55:21 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============1391466027==
Content-Type: multipart/alternative; boundary="15057753211.814F6.17278";
charset="UTF-8"
--15057753211.814F6.17278
Date: Mon, 18 Sep 2017 22:55:21 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D100105
--- Comment #1 from Jan Vesely ---
*** Testing for AMD Radeon R7 Graphics (CARRIZO / DRM 3.18.0 / 4.11.0-ROC, =
LLVM
5.0.0)
Ran 6670 tests in 785.274s
FAILED (SKIP=3D12, errors=3D580, failures=3D12)
all errors are caused by:
TypeError: This is for CUDA arrays.
I haven't investigated the failures.
There are couple of patches needed:
https://github.com/Theano/libgpuarray/pull/534
https://github.com/Theano/libgpuarray/pull/535
http://lists.llvm.org/pipermail/libclc-dev/2017-September/002449.html
and:
diff --git a/src/cluda_opencl.h b/src/cluda_opencl.h
index 6e0095c..e93aa8b 100644
--- a/src/cluda_opencl.h
+++ b/src/cluda_opencl.h
@@ -48,9 +48,9 @@ typedef struct _ga_half {
} ga_half;
#define ga_half2float(p) vload_half(0, &((p).data))
-static inline ga_half ga_float2half(ga_float f) {
+inline ga_half ga_float2half(ga_float f) {
ga_half r;
- vstore_half_rtn(f, 0, &r.data);
+ vstore_half(f, 0, &r.data);
return r;
}
diff --git a/src/gpuarray_buffer_opencl.c b/src/gpuarray_buffer_opencl.c
index 8f12811..2041ca2 100644
--- a/src/gpuarray_buffer_opencl.c
+++ b/src/gpuarray_buffer_opencl.c
@@ -146,7 +146,7 @@ cl_ctx *cl_make_ctx(cl_context ctx, gpucontext_props *p=
) {
CL_CHECKN(global_err, clGetDeviceInfo(id, CL_DEVICE_VERSION,
device_version_size,
device_version, NULL));
- if (device_version[7] =3D=3D '1' && device_version[9] < '2') {
+ if (device_version[7] =3D=3D '1' && device_version[9] < '1') {
error_set(global_err, GA_UNSUPPORTED_ERROR,
"We only support OpenCL 1.2 and up");
return NULL;
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15057753211.814F6.17278
Date: Mon, 18 Sep 2017 22:55:21 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Commen=
t # 1
on bug 10010=
5
from Jan Vesely
*** Testing for AMD Radeon R7 Graphics (CARRIZO / DRM 3.18.0 /=
4.11.0-ROC, LLVM
5.0.0)
Ran 6670 tests in 785.274s
FAILED (SKIP=3D12, errors=3D580, failures=3D12)
all errors are caused by:
TypeError: This is for CUDA arrays.
I haven't investigated the failures.
There are couple of patches needed:
https://github.c=
om/Theano/libgpuarray/pull/534
https://github.c=
om/Theano/libgpuarray/pull/535
http://lists.llvm.org/pipermail/libclc-dev/2017-September/002449.htm=
l
and:
diff --git a/src/cluda_opencl.h b/src/cluda_opencl.h
index 6e0095c..e93aa8b 100644
--- a/src/cluda_opencl.h
+++ b/src/cluda_opencl.h
@@ -48,9 +48,9 @@ typedef struct _ga_half {
} ga_half;
#define ga_half2float(p) vload_half(0, &((p).data))
-static inline ga_half ga_float2half(ga_float f) {
+inline ga_half ga_float2half(ga_float f) {
ga_half r;
- vstore_half_rtn(f, 0, &r.data);
+ vstore_half(f, 0, &r.data);
return r;
}
diff --git a/src/gpuarray_buffer_opencl.c b/src/gpuarray_buffer_opencl.c
index 8f12811..2041ca2 100644
--- a/src/gpuarray_buffer_opencl.c
+++ b/src/gpuarray_buffer_opencl.c
@@ -146,7 +146,7 @@ cl_ctx *cl_make_ctx(cl_context ctx, gpu=
context_props *p) {
CL_CHECKN(global_err, clGetDeviceInfo(id, CL_DEVICE_VERSION,
device_version_size,
device_version, NULL));
- if (device_version[7] =3D=3D '1' && device_version[9] < '2') {
+ if (device_version[7] =3D=3D '1' && device_version[9] < '1') {
error_set(global_err, GA_UNSUPPORTED_ERROR,
"We only support OpenCL 1.2 and up");
return NULL;
You are receiving this mail because:
- You are the assignee for the bug.
=
--15057753211.814F6.17278--
--===============1391466027==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============1391466027==--