From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 100941] Improve time to suspend on Radeon HD 6310 Date: Sun, 07 May 2017 08:55:11 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1767724275==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 46E046E0A9 for ; Sun, 7 May 2017 08:55:11 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1767724275== Content-Type: multipart/alternative; boundary="14941473110.dfb3F4.24491"; charset="UTF-8" --14941473110.dfb3F4.24491 Date: Sun, 7 May 2017 08:55:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D100941 Christian K=C3=B6nig changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Resolution|NOTABUG |--- Status|RESOLVED |REOPENED Priority|medium |high --- Comment #4 from Christian K=C3=B6nig --- Ah, sorry! Yes that is a known issue on APUs. See the comment in radeon_bo_evict_vram(): /* late 2.6.33 fix IGP hibernate - we need pm ops to do this correc= t */ if (0 && (rdev->flags & RADEON_IS_IGP)) { if (rdev->mc.igp_sideport_enabled =3D=3D false) /* Useless to evict on IGP chips */ return 0; } return ttm_bo_evict_mm(&rdev->mman.bdev, TTM_PL_VRAM); The problem is the driver doesn't know if we are suspending or hibernating. For pure suspending (when system memory is still being refreshed) you don't need to evict VRAM on APUs. But for hibernating (when system memory is written to disk) you need to evi= ct VRAM because the normal OS doesn't know about it and won't back it up. --=20 You are receiving this mail because: You are the assignee for the bug.= --14941473110.dfb3F4.24491 Date: Sun, 7 May 2017 08:55:11 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Christian K=C3=B6nig changed bug 10094= 1
What Removed Added
Severity normal enhancement
Resolution NOTABUG ---
Status RESOLVED REOPENED
Priority medium high

Commen= t # 4 on bug 10094= 1 from Christian K=C3=B6nig 
Ah, sorry! Yes that is a known issue on APUs.

See the comment in radeon_bo_evict_vram():

        /* late 2.6.33 fix IGP hibernate - we need pm ops to do this correc=
t */
        if (0 && (rdev->flags & RADEON_IS_IGP)) {
                if (rdev->mc.igp_sideport_enabled =3D=3D false)
                        /* Useless to evict on IGP chips */
                        return 0;
        }
        return ttm_bo_evict_mm(&rdev->mman.bdev, TTM_PL_VRAM);

The problem is the driver doesn't know if we are suspending or hibernating.

For pure suspending (when system memory is still being refreshed) you don't
need to evict VRAM on APUs.

But for hibernating (when system memory is written to disk) you need to evi=
ct
VRAM because the normal OS doesn't know about it and won't back it up.

You are receiving this mail because:
  • You are the assignee for the bug.
= --14941473110.dfb3F4.24491-- --===============1767724275== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1767724275==--