Commen=
t # 5
on bug 10159=
6
from Matias N. Goldberg
Mystery solved:
When I click the material button, this function is hit:
1 st_get_fp_variant st_program.c 1326 0x7fbb34c5c595=20
2 get_color_fp_variant st_cb_drawpixels.c 963 0x7fbb34c0ae87=20
3 st_DrawPixels st_cb_drawpixels.c 1115 0x7fbb34c0b3ea=20
4 _mesa_DrawPixels drawpix.c 163 0x7fbb3499d954=20
5 ?? 0x55b9c4a159d5=20
6 ?? 0x55b9c4a15d20=20
7 ?? 0x55b9c4a3e15c=20
8 ?? 0x55b9c4a3f956=20
9 ui_draw_but 0x55b9c4a428cb=20
10 UI_block_draw 0x55b9c49f700a=20
11 UI_panels_draw 0x55b9c4a23ede=20
12 ED_region_panels 0x55b9c4b11bbd=20
13 ?? 0x55b9c484050e=20
14 ED_region_do_draw 0x55b9c4b10837=20
15 wm_draw_update 0x55b9c4817a96=20
16 WM_main 0x55b9c4813008=20
17 main 0x55b9c47d015e=20
get_color_fp_variant ends up calling st_get_fp_variant even though
st->has_shareable_shaders is set; and st_get_fp_variant ends up creating=
a new
variant.
st_get_fp_variant will create a new variant and add it to the front of the
linked list:
fpv->next =3D stfp->variants;
stfp->variants =3D fpv;
Therefore later on st_update_fp thinks only one variant should be there, and
tries to use the first one, which is the new one created by _mesa_DrawPixel=
s;
which is wrong, triggering all the glitches.