Commen=
t # 7
on bug 10159=
6
from Matias N. Goldberg
As I keep reading the code and getting familiar, everything st=
arts making
sense:
/**
* If a shader can be created when we get its source.
* This means it has only 1 variant, not counting glBitmap and
* glDrawPixels.
*/
boolean shader_has_one_variant[MESA_SHADER_STAGES];
The problem is that after glDrawPixels creates its own variant; st_update_fp
will end up using glDrawPixels' variant, instead of the non-glDrawPixels on=
e.
The same problem happens if glBitmap is used.
One simple solution would be to add the variant to the end of the linked li=
st,
but this may affect the performance profile of radeonsi (i.e. assuming
variations created last are more likely to be used than variations created
first).
The performance concerns can be negated by adding the variation to the end =
of
the linked list ONLY if glDrawPixels or glBitmap is the caller.