From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101900] No HDMI HBR audio on Polaris (no TrueHD, no Atmos, no Neo:X, no HD Master audio) and static noise in sound when LPCM on amdgpu Xorg driver Date: Sun, 04 Mar 2018 21:48:07 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1634332191==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 73A5A6E04C for ; Sun, 4 Mar 2018 21:48:07 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1634332191== Content-Type: multipart/alternative; boundary="15202000871.0E1dfDaF0.13009" Content-Transfer-Encoding: 7bit --15202000871.0E1dfDaF0.13009 Date: Sun, 4 Mar 2018 21:48:07 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101900 --- Comment #31 from Andrew Nelson --- I have been running into the same issue. The problem seems to be that AMDGP= U is reporting that it supports 7 speakers instead of 8 in the EID. HBR formats = work with 5.1 encoded audio, but not 7.1. For some reason, the driver is configu= red to subtract 1 from the channel count before passing it into the EID. I have removed this and confirmed that 7.1 HBR audio works. Patch below: diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c index 8bfb4577b4d5..5dcc685a1379 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c @@ -557,7 +557,7 @@ void dce_aud_az_configure( /* fill audio format data */ set_reg_field_value(value, - audio_mode->channel_count - 1, + audio_mode->channel_count, =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20 AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0, MAX_CHANNELS); --=20 You are receiving this mail because: You are the assignee for the bug.= --15202000871.0E1dfDaF0.13009 Date: Sun, 4 Mar 2018 21:48:07 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 31 on bug 10190= 0 from Andrew Nelson 
I have been running into the same issue. The problem seems to =
be that AMDGPU is
reporting that it supports 7 speakers instead of 8 in the EID. HBR formats =
work
with 5.1 encoded audio, but not 7.1. For some reason, the driver is configu=
red
to subtract 1 from the channel count before passing it into the EID. I have
removed this and confirmed that 7.1 HBR audio works. Patch below:

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
index 8bfb4577b4d5..5dcc685a1379 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c
@@ -557,7 +557,7 @@ void dce_aud_az_configure(

                        /* fill audio format data */
                        set_reg_field_value(value,
-                                       audio_mode->channel_count - 1,
+                                       audio_mode->channel_count,
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20
AZALIA_F0_CODEC_PIN_CONTROL_AUDIO_DESCRIPTOR0,
                                        MAX_CHANNELS);

You are receiving this mail because:
  • You are the assignee for the bug.
= --15202000871.0E1dfDaF0.13009-- --===============1634332191== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1634332191==--