From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 101900] No HDMI HBR audio on Polaris (no TrueHD, no Atmos, no
Neo:X, no HD Master audio)
Date: Tue, 05 Dec 2017 14:41:22 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0522299203=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[131.252.210.165])
by gabe.freedesktop.org (Postfix) with ESMTP id B39366E57F
for ; Tue, 5 Dec 2017 14:41:22 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============0522299203==
Content-Type: multipart/alternative; boundary="15124848822.9648eE.3006";
charset="UTF-8"
--15124848822.9648eE.3006
Date: Tue, 5 Dec 2017 14:41:22 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D101900
--- Comment #15 from lethalwp@gmail.com ---
dc_log enabled:
:~# dmesg | grep drm
[ 1.413712] [drm] amdgpu kernel modesetting enabled.
[ 1.420821] fb: switching to amdgpudrmfb from VESA VGA
[ 1.421365] [drm] initializing kernel modesetting (POLARIS12 0x1002:0x69=
9F
0x1DA2:0xE367 0xC7).
[ 1.421375] [drm] register mmio base: 0xFF9C0000
[ 1.421376] [drm] register mmio size: 262144
[ 1.421386] [drm] probing gen 2 caps for device 8086:277d =3D 2012501/0
[ 1.421387] [drm] probing mlw for device 8086:277d =3D 2012501
[ 1.421395] [drm] UVD is enabled in VM mode
[ 1.421396] [drm] UVD ENC is enabled in VM mode
[ 1.421398] [drm] VCE enabled in VM mode
[ 1.422382] [drm] GPU post is not needed
[ 1.422402] [drm] vm size is 64 GB, block size is 13-bit, fragment size =
is
9-bit
[ 1.422452] [drm] Detected VRAM RAM=3D2048M, BAR=3D256M
[ 1.422453] [drm] RAM width 128bits GDDR5
[ 1.422538] [drm] amdgpu: 2048M of VRAM memory ready
[ 1.422539] [drm] amdgpu: 3072M of GTT memory ready.
[ 1.422547] [drm] GART: num cpu pages 65536, num gpu pages 65536
[ 1.422597] [drm] PCIE GART of 256M enabled (table at 0x000000F400040000=
).
[ 1.422690] [drm] amdgpu: irq initialized.
[ 1.422768] [drm] Chained IB support enabled!
[ 1.424499] [drm] Found UVD firmware Version: 1.79 Family ID: 16
[ 1.425670] [drm] Found VCE firmware Version: 52.4 Binary ID: 3
[ 1.505597] [drm] DM_PPLIB: values for Engine clock
[ 1.505599] [drm] DM_PPLIB: 21400
[ 1.505600] [drm] DM_PPLIB: 55100
[ 1.505600] [drm] DM_PPLIB: 73400
[ 1.505601] [drm] DM_PPLIB: 98000
[ 1.505601] [drm] DM_PPLIB: 104600
[ 1.505602] [drm] DM_PPLIB: 109800
[ 1.505602] [drm] DM_PPLIB: 112400
[ 1.505603] [drm] DM_PPLIB: 120600
[ 1.505603] [drm] DM_PPLIB: Warning: using default validation clocks!
[ 1.505604] [drm] DM_PPLIB: Validation clocks:
[ 1.505605] [drm] DM_PPLIB: engine_max_clock: 72000
[ 1.505605] [drm] DM_PPLIB: memory_max_clock: 80000
[ 1.505606] [drm] DM_PPLIB: level : 0
[ 1.505606] [drm] DM_PPLIB: reducing engine clock level from 8 to 2
[ 1.505608] [drm] DM_PPLIB: values for Memory clock
[ 1.505608] [drm] DM_PPLIB: 30000
[ 1.505609] [drm] DM_PPLIB: 62500
[ 1.505609] [drm] DM_PPLIB: 175000
[ 1.505610] [drm] DM_PPLIB: Warning: using default validation clocks!
[ 1.505611] [drm] DM_PPLIB: Validation clocks:
[ 1.505611] [drm] DM_PPLIB: engine_max_clock: 72000
[ 1.505612] [drm] DM_PPLIB: memory_max_clock: 80000
[ 1.505612] [drm] DM_PPLIB: level : 0
[ 1.505613] [drm] DM_PPLIB: reducing memory clock level from 3 to 2
[ 1.505615] [drm] DC: create_links: connectors_num: physical:3, virtual:0
[ 1.505620] [drm] Connector[0] description:signal 32
[ 1.505637] [drm] Connector[1] description:signal 4
[ 1.505650] [drm] Connector[2] description:signal 2
[ 1.515049] [drm] Display Core initialized
[ 1.515051] [drm] Display Core initialized!
[ 1.515588] [drm] link=3D0, dc_sink_in=3D (null) is now Disconn=
ected
[ 1.540524] [drm] [Detect] [HDMIA][ConnIdx:1] DENON-AVAMP: [Block 0] 0=
0 FF
FF FF FF FF FF 00 11 EE 29 00 01 01 01 01 00 15 01 03 80 00 00 78 0A DA FF =
A3
58 4A A2 29 17 49 4B 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 =
01
01 1D 80 D0 72 1C 16 20 10 2C 25 80 9A 26 53 00 00 9E 01 1D 80 18 71 1C 16 =
20
58 2C 25 00 9A 26 53 00 00 9E 00 00 00 FC 00 44 45 4E 4F 4E 2D 41 56 41 4D =
50
0A 20 00 00 00 FD 00 17 3D 0F 44 0F 00 0A 20 20 20 20 20 20 01 CA ^
[ 1.540538] [drm] [Detect] [HDMIA][ConnIdx:1] DENON-AVAMP: [Block 1] 0=
2 03
3B 72 58 13 04 94 85 1F 10 20 12 03 11 02 16 07 15 06 01 0E 23 0F 24 1D 25 =
1E
26 32 0F 7F 07 3D 1E C0 15 07 50 5F 7E 01 57 06 00 67 7E 00 83 5F 00 00 66 =
03
0C 00 12 00 80 01 1D 80 D0 72 1C 16 20 10 2C 25 80 9A 26 53 00 00 9E 8C 0A =
D0
90 20 40 31 20 0C 40 55 00 9A 26 53 00 00 18 01 1D 80 18 71 1C 16 20 58 2C =
25
00 9A 26 53 00 00 9E 00 00 00 00 00 00 00 00 00 00 00 00 00 00 CB ^
[ 1.540541] [drm] dc_link_detect: manufacturer_id =3D EE11, product_id =
=3D 29,
serial_number =3D 1010101, manufacture_week =3D 0, manufacture_year =3D 21,
display_name =3D DENON-AVAMP, speaker_flag =3D 95, audio_mode_count =3D 6
[ 1.540542] [drm] dc_link_detect: mode number =3D 0, format_code =3D 1,
channel_count =3D 7, sample_rate =3D 127, sample_size =3D 7
[ 1.540543] [drm] dc_link_detect: mode number =3D 1, format_code =3D 7,
channel_count =3D 5, sample_rate =3D 30, sample_size =3D 192
[ 1.540545] [drm] dc_link_detect: mode number =3D 2, format_code =3D 2,
channel_count =3D 5, sample_rate =3D 7, sample_size =3D 80
[ 1.540546] [drm] dc_link_detect: mode number =3D 3, format_code =3D 11,
channel_count =3D 7, sample_rate =3D 126, sample_size =3D 1
[ 1.540547] [drm] dc_link_detect: mode number =3D 4, format_code =3D 10,
channel_count =3D 7, sample_rate =3D 6, sample_size =3D 0
[ 1.540549] [drm] dc_link_detect: mode number =3D 5, format_code =3D 12,
channel_count =3D 7, sample_rate =3D 126, sample_size =3D 0
[ 1.540550] [drm] link=3D1, dc_sink_in=3D00000000cf1ce385 is now Connect=
ed
[ 1.540658] [drm] link=3D2, dc_sink_in=3D (null) is now Disconn=
ected
[ 1.540663] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[ 1.540664] [drm] Driver supports precise vblank timestamp query.
[ 1.541992] [drm] ring test on 0 succeeded in 14 usecs
[ 1.542810] [drm] ring test on 9 succeeded in 12 usecs
[ 1.542833] [drm] ring test on 1 succeeded in 10 usecs
[ 1.542842] [drm] ring test on 2 succeeded in 3 usecs
[ 1.542851] [drm] ring test on 3 succeeded in 3 usecs
[ 1.542860] [drm] ring test on 4 succeeded in 3 usecs
[ 1.542886] [drm] ring test on 5 succeeded in 12 usecs
[ 1.542895] [drm] ring test on 6 succeeded in 3 usecs
[ 1.542905] [drm] ring test on 7 succeeded in 3 usecs
[ 1.542914] [drm] ring test on 8 succeeded in 3 usecs
[ 1.542971] [drm] ring test on 10 succeeded in 6 usecs
[ 1.542982] [drm] ring test on 11 succeeded in 6 usecs
[ 1.589877] [drm] ring test on 12 succeeded in 1 usecs
[ 1.589925] [drm] ring test on 13 succeeded in 19 usecs
[ 1.589935] [drm] ring test on 14 succeeded in 3 usecs
[ 1.589936] [drm] UVD and UVD ENC initialized successfully.
[ 1.700851] [drm] ring test on 15 succeeded in 6 usecs
[ 1.700862] [drm] ring test on 16 succeeded in 3 usecs
[ 1.700862] [drm] VCE initialized successfully.
[ 1.701192] [drm] ib test on ring 0 succeeded
[ 1.701356] [drm] ib test on ring 1 succeeded
[ 1.701404] [drm] ib test on ring 2 succeeded
[ 1.701452] [drm] ib test on ring 3 succeeded
[ 1.701500] [drm] ib test on ring 4 succeeded
[ 1.701548] [drm] ib test on ring 5 succeeded
[ 1.701596] [drm] ib test on ring 6 succeeded
[ 1.701644] [drm] ib test on ring 7 succeeded
[ 1.701700] [drm] ib test on ring 8 succeeded
[ 2.208003] [drm] ib test on ring 9 succeeded
[ 2.208045] [drm] ib test on ring 10 succeeded
[ 2.208075] [drm] ib test on ring 11 succeeded
[ 2.209590] [drm] ib test on ring 12 succeeded
[ 2.209923] [drm] ib test on ring 13 succeeded
[ 2.210201] [drm] ib test on ring 14 succeeded
[ 2.210446] [drm] ib test on ring 15 succeeded
[ 2.212094] [drm] fb mappable at 0xD03F2000
[ 2.212095] [drm] vram apper at 0xD0000000
[ 2.212096] [drm] size 8294400
[ 2.212097] [drm] fb depth is 24
[ 2.212098] [drm] pitch is 7680
[ 2.212174] fbcon: amdgpudrmfb (fb0) is primary device
[ 2.212733] [drm] dc_commit_state: 1 streams
[ 2.212736] [drm] core_stream 0x7369a800: src: 0, 0, 1920, 1080; dst: 0,=
0,
1920, 1080, colorSpace:4
[ 2.212737] [drm] pix_clk_khz: 148500, h_total: 2200, v_total: 1125,
pixelencoder:3, displaycolorDepth:2
[ 2.212738] [drm] sink name: DENON-AVAMP, serial: 16843009
[ 2.212739] [drm] link: 1
[ 2.231575] [drm] [Mode] [HDMIA][ConnIdx:1] {1920x1080,
2200x1125@148500Khz}^
[ 2.271162] amdgpu 0000:05:00.0: fb0: amdgpudrmfb frame buffer device
[ 2.277167] [drm] Initialized amdgpu 3.23.0 20150101 for 0000:05:00.0 on
minor 0
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15124848822.9648eE.3006
Date: Tue, 5 Dec 2017 14:41:22 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Comme=
nt # 15
on bug 10190=
0
from lethalwp@gmail=
.com
dc_log enabled:
:~# dmesg | grep drm
[ 1.413712] [drm] amdgpu kernel modesetting enabled.
[ 1.420821] fb: switching to amdgpudrmfb from VESA VGA
[ 1.421365] [drm] initializing kernel modesetting (POLARIS12 0x1002:0x69=
9F
0x1DA2:0xE367 0xC7).
[ 1.421375] [drm] register mmio base: 0xFF9C0000
[ 1.421376] [drm] register mmio size: 262144
[ 1.421386] [drm] probing gen 2 caps for device 8086:277d =3D 2012501/0
[ 1.421387] [drm] probing mlw for device 8086:277d =3D 2012501
[ 1.421395] [drm] UVD is enabled in VM mode
[ 1.421396] [drm] UVD ENC is enabled in VM mode
[ 1.421398] [drm] VCE enabled in VM mode
[ 1.422382] [drm] GPU post is not needed
[ 1.422402] [drm] vm size is 64 GB, block size is 13-bit, fragment size =
is
9-bit
[ 1.422452] [drm] Detected VRAM RAM=3D2048M, BAR=3D256M
[ 1.422453] [drm] RAM width 128bits GDDR5
[ 1.422538] [drm] amdgpu: 2048M of VRAM memory ready
[ 1.422539] [drm] amdgpu: 3072M of GTT memory ready.
[ 1.422547] [drm] GART: num cpu pages 65536, num gpu pages 65536
[ 1.422597] [drm] PCIE GART of 256M enabled (table at 0x000000F400040000=
).
[ 1.422690] [drm] amdgpu: irq initialized.
[ 1.422768] [drm] Chained IB support enabled!
[ 1.424499] [drm] Found UVD firmware Version: 1.79 Family ID: 16
[ 1.425670] [drm] Found VCE firmware Version: 52.4 Binary ID: 3
[ 1.505597] [drm] DM_PPLIB: values for Engine clock
[ 1.505599] [drm] DM_PPLIB: 21400
[ 1.505600] [drm] DM_PPLIB: 55100
[ 1.505600] [drm] DM_PPLIB: 73400
[ 1.505601] [drm] DM_PPLIB: 98000
[ 1.505601] [drm] DM_PPLIB: 104600
[ 1.505602] [drm] DM_PPLIB: 109800
[ 1.505602] [drm] DM_PPLIB: 112400
[ 1.505603] [drm] DM_PPLIB: 120600
[ 1.505603] [drm] DM_PPLIB: Warning: using default validation clocks!
[ 1.505604] [drm] DM_PPLIB: Validation clocks:
[ 1.505605] [drm] DM_PPLIB: engine_max_clock: 72000
[ 1.505605] [drm] DM_PPLIB: memory_max_clock: 80000
[ 1.505606] [drm] DM_PPLIB: level : 0
[ 1.505606] [drm] DM_PPLIB: reducing engine clock level from 8 to 2
[ 1.505608] [drm] DM_PPLIB: values for Memory clock
[ 1.505608] [drm] DM_PPLIB: 30000
[ 1.505609] [drm] DM_PPLIB: 62500
[ 1.505609] [drm] DM_PPLIB: 175000
[ 1.505610] [drm] DM_PPLIB: Warning: using default validation clocks!
[ 1.505611] [drm] DM_PPLIB: Validation clocks:
[ 1.505611] [drm] DM_PPLIB: engine_max_clock: 72000
[ 1.505612] [drm] DM_PPLIB: memory_max_clock: 80000
[ 1.505612] [drm] DM_PPLIB: level : 0
[ 1.505613] [drm] DM_PPLIB: reducing memory clock level from 3 to 2
[ 1.505615] [drm] DC: create_links: connectors_num: physical:3, virtual:0
[ 1.505620] [drm] Connector[0] description:signal 32
[ 1.505637] [drm] Connector[1] description:signal 4
[ 1.505650] [drm] Connector[2] description:signal 2
[ 1.515049] [drm] Display Core initialized
[ 1.515051] [drm] Display Core initialized!
[ 1.515588] [drm] link=3D0, dc_sink_in=3D (null) is now Disconn=
ected
[ 1.540524] [drm] [Detect] [HDMIA][ConnIdx:1] DENON-AVAMP: [Block 0] 0=
0 FF
FF FF FF FF FF 00 11 EE 29 00 01 01 01 01 00 15 01 03 80 00 00 78 0A DA FF =
A3
58 4A A2 29 17 49 4B 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 =
01
01 1D 80 D0 72 1C 16 20 10 2C 25 80 9A 26 53 00 00 9E 01 1D 80 18 71 1C 16 =
20
58 2C 25 00 9A 26 53 00 00 9E 00 00 00 FC 00 44 45 4E 4F 4E 2D 41 56 41 4D =
50
0A 20 00 00 00 FD 00 17 3D 0F 44 0F 00 0A 20 20 20 20 20 20 01 CA ^
[ 1.540538] [drm] [Detect] [HDMIA][ConnIdx:1] DENON-AVAMP: [Block 1] 0=
2 03
3B 72 58 13 04 94 85 1F 10 20 12 03 11 02 16 07 15 06 01 0E 23 0F 24 1D 25 =
1E
26 32 0F 7F 07 3D 1E C0 15 07 50 5F 7E 01 57 06 00 67 7E 00 83 5F 00 00 66 =
03
0C 00 12 00 80 01 1D 80 D0 72 1C 16 20 10 2C 25 80 9A 26 53 00 00 9E 8C 0A =
D0
90 20 40 31 20 0C 40 55 00 9A 26 53 00 00 18 01 1D 80 18 71 1C 16 20 58 2C =
25
00 9A 26 53 00 00 9E 00 00 00 00 00 00 00 00 00 00 00 00 00 00 CB ^
[ 1.540541] [drm] dc_link_detect: manufacturer_id =3D EE11, product_id =
=3D 29,
serial_number =3D 1010101, manufacture_week =3D 0, manufacture_year =3D 21,
display_name =3D DENON-AVAMP, speaker_flag =3D 95, audio_mode_count =3D 6
[ 1.540542] [drm] dc_link_detect: mode number =3D 0, format_code =3D 1,
channel_count =3D 7, sample_rate =3D 127, sample_size =3D 7
[ 1.540543] [drm] dc_link_detect: mode number =3D 1, format_code =3D 7,
channel_count =3D 5, sample_rate =3D 30, sample_size =3D 192
[ 1.540545] [drm] dc_link_detect: mode number =3D 2, format_code =3D 2,
channel_count =3D 5, sample_rate =3D 7, sample_size =3D 80
[ 1.540546] [drm] dc_link_detect: mode number =3D 3, format_code =3D 11,
channel_count =3D 7, sample_rate =3D 126, sample_size =3D 1
[ 1.540547] [drm] dc_link_detect: mode number =3D 4, format_code =3D 10,
channel_count =3D 7, sample_rate =3D 6, sample_size =3D 0
[ 1.540549] [drm] dc_link_detect: mode number =3D 5, format_code =3D 12,
channel_count =3D 7, sample_rate =3D 126, sample_size =3D 0
[ 1.540550] [drm] link=3D1, dc_sink_in=3D00000000cf1ce385 is now Connect=
ed
[ 1.540658] [drm] link=3D2, dc_sink_in=3D (null) is now Disconn=
ected
[ 1.540663] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[ 1.540664] [drm] Driver supports precise vblank timestamp query.
[ 1.541992] [drm] ring test on 0 succeeded in 14 usecs
[ 1.542810] [drm] ring test on 9 succeeded in 12 usecs
[ 1.542833] [drm] ring test on 1 succeeded in 10 usecs
[ 1.542842] [drm] ring test on 2 succeeded in 3 usecs
[ 1.542851] [drm] ring test on 3 succeeded in 3 usecs
[ 1.542860] [drm] ring test on 4 succeeded in 3 usecs
[ 1.542886] [drm] ring test on 5 succeeded in 12 usecs
[ 1.542895] [drm] ring test on 6 succeeded in 3 usecs
[ 1.542905] [drm] ring test on 7 succeeded in 3 usecs
[ 1.542914] [drm] ring test on 8 succeeded in 3 usecs
[ 1.542971] [drm] ring test on 10 succeeded in 6 usecs
[ 1.542982] [drm] ring test on 11 succeeded in 6 usecs
[ 1.589877] [drm] ring test on 12 succeeded in 1 usecs
[ 1.589925] [drm] ring test on 13 succeeded in 19 usecs
[ 1.589935] [drm] ring test on 14 succeeded in 3 usecs
[ 1.589936] [drm] UVD and UVD ENC initialized successfully.
[ 1.700851] [drm] ring test on 15 succeeded in 6 usecs
[ 1.700862] [drm] ring test on 16 succeeded in 3 usecs
[ 1.700862] [drm] VCE initialized successfully.
[ 1.701192] [drm] ib test on ring 0 succeeded
[ 1.701356] [drm] ib test on ring 1 succeeded
[ 1.701404] [drm] ib test on ring 2 succeeded
[ 1.701452] [drm] ib test on ring 3 succeeded
[ 1.701500] [drm] ib test on ring 4 succeeded
[ 1.701548] [drm] ib test on ring 5 succeeded
[ 1.701596] [drm] ib test on ring 6 succeeded
[ 1.701644] [drm] ib test on ring 7 succeeded
[ 1.701700] [drm] ib test on ring 8 succeeded
[ 2.208003] [drm] ib test on ring 9 succeeded
[ 2.208045] [drm] ib test on ring 10 succeeded
[ 2.208075] [drm] ib test on ring 11 succeeded
[ 2.209590] [drm] ib test on ring 12 succeeded
[ 2.209923] [drm] ib test on ring 13 succeeded
[ 2.210201] [drm] ib test on ring 14 succeeded
[ 2.210446] [drm] ib test on ring 15 succeeded
[ 2.212094] [drm] fb mappable at 0xD03F2000
[ 2.212095] [drm] vram apper at 0xD0000000
[ 2.212096] [drm] size 8294400
[ 2.212097] [drm] fb depth is 24
[ 2.212098] [drm] pitch is 7680
[ 2.212174] fbcon: amdgpudrmfb (fb0) is primary device
[ 2.212733] [drm] dc_commit_state: 1 streams
[ 2.212736] [drm] core_stream 0x7369a800: src: 0, 0, 1920, 1080; dst: 0,=
0,
1920, 1080, colorSpace:4
[ 2.212737] [drm] pix_clk_khz: 148500, h_total: 2200, v_total: 1125,
pixelencoder:3, displaycolorDepth:2
[ 2.212738] [drm] sink name: DENON-AVAMP, serial: 16843009
[ 2.212739] [drm] link: 1
[ 2.231575] [drm] [Mode] [HDMIA][ConnIdx:1] {1920x1080,
2200x1125@148500Khz}^
[ 2.271162] amdgpu 0000:05:00.0: fb0: amdgpudrmfb frame buffer device
[ 2.277167] [drm] Initialized amdgpu 3.23.0 20150101 for 0000:05:00.0 on
minor 0
You are receiving this mail because:
- You are the assignee for the bug.
=
--15124848822.9648eE.3006--
--===============0522299203==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============0522299203==--