[Bug 101978] [bisected] war thunder performance reduced by ~28%

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1816 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

            Bug ID: 101978
           Summary: [bisected] war thunder performance reduced by ~28%
           Product: Mesa
           Version: git
          Hardware: Other
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: higuita@gmx.net
        QA Contact: dri-devel@lists.freedesktop.org

Since sometime i notice that war thunder is running slower on my machine using
mesa-git, but as the game is always updating, i (wrongly) blamed some game
update. 

Yet, some days ago, after a test with a steamOS, i could confirm that older
mesa versions worked faster than mesa-git, with the same game version. I
excluded the kernel version, so i have done a mesa bisect and found the (old)
commit that made war thunder lost about 28% performance on my setup (RX480 on a
A10-7850k):

commit ac6007460adaf4bb21028a3281ec622d1e43df49
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Wed Feb 15 19:50:15 2017 +0100

    radeonsi: upload constants into VRAM instead of GTT

    This lowers lgkm wait cycles by 30% on VI and normal conditions.
    The might be a measurable improvement when CE is disabled (radeon)
    or under L2 thrashing.


I'm running slackware64 -current, with kernel 4.12.1, LLVM 4.0.1 and the game
is free, so you can test it. For the bisect i started the game, run the CPU
benchmark (as workaround some bug where most first benchmarks are slower) and
then run the  "still scene" benchmark. as is the shorter one, but all others 
had performance drop.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3256 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #1 from higuita@gmx.net ---
Running some of the other benchmarks, i get this:

Benchmark       good    bad     %

patrick         4082    3173    -22
plane           2001    1793    -10
tank (cpu)      1320    1094    -17
tanks           1706    1431    -16

in other benchmarks, the commit did not make much difference, specially on
planes, but on tanks it did a lot, "test drive" with the chi-nu tank (ie: as in
real game play) i get this fps reduction:

chi nu test     25      14      -44%

I also notice that the GPU load also drop mostly in the same degree, but the
sclk get a little higer with more spikes.for the "still scene", where i get
-28% performance, the gpu load drops 32% and about 330-370MHz for before the
commit, but 320-390MHz after the commit

GPU load        55      37      -32
sclk          330-370 320-380

Can a apitrace help in anyway to understand why this affects so much this game

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1859 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 414 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #2 from Michel Dänzer <michel@daenzer.net> ---
(In reply to higuita from comment #1)
> Can a apitrace help in anyway to understand why this affects so much this
> game

Possibly.

Also, there are amdgpu kernel driver changes lined up for 4.14 that might help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1274 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
(In reply to Michel Dänzer from comment #2)
> (In reply to higuita from comment #1)
> > Can a apitrace help in anyway to understand why this affects so much this
> > game
> 
> Possibly.
> 
> Also, there are amdgpu kernel driver changes lined up for 4.14 that might
> help.

Is it the work by John Brooks?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1429 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 396 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #4 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Marek Olšák from comment #3)
> > Also, there are amdgpu kernel driver changes lined up for 4.14 that might
> > help.
> 
> Is it the work by John Brooks?

Him and yours truly, yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1268 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 614 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #5 from higuita@gmx.net ---
I'm not very familiar with apitrace, so i generated a 2.6GB trace, locate here:
http://motaleite.net/~higuita/warthunder/aces.trace

The replay also look broken, do not know if its some bug or its normal

Anyway, 1 minute after starting you get a long benchmark run where you can
notice in a RX480 (and probably other GPUs of the same family or even in all
amdgpu ) that the GPU load is low (~30% here), sclk also low (~350-450Mhz)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1437 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

Justin <jnroby84@outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|git                         |17.2
           Hardware|Other                       |x86-64 (AMD64)

--- Comment #6 from Justin <jnroby84@outlook.com> ---
Setting, echo high >
/sys/class/drm/card0/device/power_dpm_force_performance_level
Seems to help, even in the main menu, I will be getting 26 FPS at medium
settings. setting that used to bring me up to about 45 seems to not be working
any more.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2155 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 479 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #7 from higuita@gmx.net ---
>Also, there are amdgpu kernel driver changes lined up for 4.14 that might help.

Updates to 4.14 and i fail to see any improvement, sclk is still low,
performance is still very low for what this card is capable. Or is there any
new setting that i have to enable/change to get a possible improvement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1267 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1918 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #8 from Konstantin A. Lepikhov <lakostis@altlinux.org> ---
I observe the same behavior with 17.3.3, maybe we should reassign to 17.3
version?

[lakostis@lks ~]$ glxinfo -B
name of display: :0.0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: X.Org (0x1002)
    Device: AMD Radeon (TM) R9 Fury Series (FIJI / DRM 3.23.0 /
4.14.0-lks-wks-alt8, LLVM 6.0.0) (0x7300)
    Version: 17.3.3
    Accelerated: yes
    Video memory: 4060MB
    Unified memory: no
    Preferred profile: core (0x1)
    Max core profile version: 4.5
    Max compat profile version: 3.0
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.1
Memory info (GL_ATI_meminfo):
    VBO free memory - total: 4059 MB, largest block: 4059 MB
    VBO free aux. memory - total: 4092 MB, largest block: 4092 MB
    Texture free memory - total: 4059 MB, largest block: 4059 MB
    Texture free aux. memory - total: 4092 MB, largest block: 4092 MB
    Renderbuffer free memory - total: 4059 MB, largest block: 4059 MB
    Renderbuffer free aux. memory - total: 4092 MB, largest block: 4092 MB
Memory info (GL_NVX_gpu_memory_info):
    Dedicated video memory: 4060 MB
    Total available memory: 8153 MB
    Currently available dedicated video memory: 4059 MB
OpenGL vendor string: X.Org
OpenGL renderer string: AMD Radeon (TM) R9 Fury Series (FIJI / DRM 3.23.0 /
4.14.0-lks-wks-alt8, LLVM 6.0.0)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.3.3
(git-80f5f27)

The GPU runs fine other tasks and benchmarks only WarThunder is slow. BTW If
GALLIUM_HUD is enabled with buffer_wait_time, those values are very high for
this kind of workload (~100-120ms), normally they're in us, not ms.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2719 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 593 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #9 from Konstantin A. Lepikhov <lakostis@altlinux.org> ---
BTW running warthunder under brand new 4.15 kernel + latest amd-staging-4.15
gives 25-30+ FPS and the same during the gameplay with performance set to
'auto' and fps spikes up to 50+ with 'high' performance on my R9 Fury.

But it seems that 4.15 vanilla kernel doesn't have any patches from staging
which improve performance so the results are nearly the same as it was with
4.14.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1390 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 507 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

Gregor Münch <gr.muench@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |77449


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=77449
[Bug 77449] Tracker bug for all bugs related to Steam titles
-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1563 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 719 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #10 from Timothy Arceri <t_arceri@yahoo.com.au> ---
(In reply to Konstantin A. Lepikhov from comment #9)
> BTW running warthunder under brand new 4.15 kernel + latest amd-staging-4.15
> gives 25-30+ FPS and the same during the gameplay with performance set to
> 'auto' and fps spikes up to 50+ with 'high' performance on my R9 Fury.
> 
> But it seems that 4.15 vanilla kernel doesn't have any patches from staging
> which improve performance so the results are nearly the same as it was with
> 4.14.

Has the performance now been fixed for you with 4.{16,17,18}?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1598 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1510 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #11 from higuita@gmx.net ---
As we can't control the installed game version (auto-update to startup), we
can't now test the older opengl4 version anymore, where this problem was found.
Before the upgrade that removed the opengl4, i got higher fps with
power_dpm_force_performance_level setting set to high. That was with kernel
4.16 or 4.17

Warthunder dropped the opengl4 engine (only used in linux) and reverted to the
opengl3 (also used in MacOS) for linux. They did this because they were making
big changed in the engine and supporting the opengl4 only for linux was a waste
of time when they are also adding vulkan support (not yet enabled by default,
but one can enable it changing the config file). This vulkan support is still
not complete (some drivers have rendering bugs, i can see some micro-freezes
sometimes), but the future looks promising.

With opengl3 in the 4.18.9 kernel, at least for me (rx480 and latest mesa),
performance increased about 20% over opengl4 (but again, comparing different
engine versions)
With Vulkan, i get always 60fps (vsync is enabled) and the GPU is using the top
sclk speed, so at least vulkan is working fine.


So i vote to close this "obsolete" or similar, as we can't test it anymore.
Also, probably next version (probably around the end of year) will release the
vulkan support for all OS.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2278 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1113 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

--- Comment #12 from Konstantin A. Lepikhov <lakostis@altlinux.org> ---
(In reply to Timothy Arceri from comment #10)
> (In reply to Konstantin A. Lepikhov from comment #9)
> > BTW running warthunder under brand new 4.15 kernel + latest amd-staging-4.15
> > gives 25-30+ FPS and the same during the gameplay with performance set to
> > 'auto' and fps spikes up to 50+ with 'high' performance on my R9 Fury.
> > 
> > But it seems that 4.15 vanilla kernel doesn't have any patches from staging
> > which improve performance so the results are nearly the same as it was with
> > 4.14.
> 
> Has the performance now been fixed for you with 4.{16,17,18}?

Just tested w/ 4.19.8 + Mesa 18.3.0 on R9 Fury and latest WT client -
everything became even worse, missing textures, white screen, so the game now
is totally unplayable. But I know they have problems with nvidia as well, and
their vulkan never worked on my box (black screen on focus).

So no progress so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2071 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101978] [bisected] war thunder performance reduced by ~28%

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1158 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101978

Timothy Arceri <t_arceri@yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #13 from Timothy Arceri <t_arceri@yahoo.com.au> ---
(In reply to Konstantin A. Lepikhov from comment #12)
> Just tested w/ 4.19.8 + Mesa 18.3.0 on R9 Fury and latest WT client -
> everything became even worse, missing textures, white screen, so the game
> now is totally unplayable. But I know they have problems with nvidia as
> well, and their vulkan never worked on my box (black screen on focus).
> 
> So no progress so far.

These are all different issues from the original bug report and are probably
game bugs if Nvidia is also having issues. As per comment 11 I'm closing this
bug (using INVALID for lack of a better option).

Any new issues should have new bug reports opened for them.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2804 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel