Commen=
t # 2
on bug 10200=
6
from Julien Isorce
Comment on attac=
hment 133180 [details] [review=
]
proposed patch by Julien Isorce
commit 91d93aa62162f98d6377e5c796b63faa263f2c18
Author: Julien Isorce <ju=
lien.isorce@gmail.com>
Date: Tue Jul 25 15:31:28 2017 +0100
st/va: change frame_idx from array to hash table
The picture_id was assumed to be a frame number so in 0-31.
But the vaapi client gstreamer-vaapi uses the surfaces handles
as identifier which are unsigned int.
This bug can happen when using a lot of vaapi surfaces within
the same process. Indeed Mesa/st/va increments a counter for the
surface ID: mesa/util/u_handle_table.c::handle_table_add which
starts from 0 and incremented by 1 at each call.
So creating more than 32 surfaces was a problem.
The following bug contains a test that reproduces the problem
by running a couple of vaapih264enc in the same process. The
above also explains why there was no pb when running them in
separated processes.
Bugzilla: https://bugs.freedesktop.org/show_bug.=
cgi?id=3D102006
Signed-off-by: Julien Isorce <jisorce@oblong.com>
Tested-by: Tomas Rataj <rat=
aj28@gmail.com>
Acked-by: Christian K=C3=B6nig <christian.koenig@amd.com>
Reviewed-and-tested-by: Boyuan Zhang <Boyuan.Zhang@amd.com>