| Bug ID | 102552 |
|---|---|
| Summary | Null dereference due to not checking return value of util_for= mat_description |
| Product | Mesa |
| Version | git |
| Hardware | x86-64 (AMD64) |
| OS | All |
| Status | NEW |
| Severity | enhancement |
| Priority | medium |
| Component | Drivers/Gallium/r600 |
| Assignee | dri-devel@lists.freedesktop.org |
| Reporter | pauk.denis@gmail.com |
| QA Contact | dri-devel@lists.freedesktop.org |
In case unsupported format util_format_description return NULL= , and dereference will produce segffault.
| What | Removed | Added |
|---|---|---|
| CC | pauk.denis@gmail.com |
Created attachment 133978 [details] [review] gallium/{r600,radeonsi}: Fix segfault with color format Possible fix for r600/radionsi
What format is this happening with? There should be a descript= ion for every format, maybe except PIPE_FORMAT_NONE.
I have found this behaiviour because of error in my code when =
some time
is_format_supported called with uninitialized value and had value >
PIPE_FORMAT_COUNT.=20
With check like:
-----
for(int i=3D0; i<PIPE_FORMAT_COUNT; i++) {
pscreen->is_format_supported(pscreen, i, PIPE_TEXTURE_2D, 0,
PIPE_BIND_SAMPLER_VIEW);
}
-----
Such code has possible issues with: 73, 78, 79, 80, 81, 86 (holes in enum
pipe_format).
Oh interesting. I think some of those formats were removed rec= ently. I wonder if such call sites should be fixed. Nouveau calls util_format_is_supported = up high in is_format_supported, I suspect that gets it out of trouble. Either way, is_format_supported or its callers should be fixed, not utility functions like util_format_get_first_non_void_channel.
| What | Removed | Added |
|---|---|---|
| Attachment #133978 is obsolete | 1 |
Created attachment 134056 [details] [review] Updated version with changes related only to *_supported functions. I have deleted all changes not realted to *_supported functions. Change in src/gallium/auxiliary/util/u_format.c:util_format_is_supported - check that value of format in correct range (<PIPE_FORMAT_COUNT). Changes in src/gallium/drivers/{r600,radeonsi} - check for holes in format values.