dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 103544] Graphical glitches r600 in game this war of mine linux native
Date: Sat, 04 Nov 2017 03:21:39 +0000	[thread overview]
Message-ID: <bug-103544-502-WfaD90ucyS@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-103544-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1495 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=103544

--- Comment #6 from Ilia Mirkin <imirkin@alum.mit.edu> ---
(In reply to Roland Scheidegger from comment #5)
> I've actually got that game myself here.
> So I did the bisect and the winner is:
> ce7a045feeef8cad155f1c9aa07f166e146e3d00 is the first bad commit
> commit ce7a045feeef8cad155f1c9aa07f166e146e3d00
> Author: Ilia Mirkin <imirkin@alum.mit.edu>
> Date:   Mon Jan 23 20:53:50 2017 -0500
> 
>     r600g: use ieee variants of multiplication instructions
>     
>     This matches the behavior of most other drivers, including nouveau,
>     radeonsi, and i965.
>     
>     Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
>     Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
> 
> Looks like some numerical issue then, albeit I don't know if the game is at
> fault here.

Apologies for the trouble.

The main difference between IEEE and non-IEEE is whether 0 * infinity = 0 or
NaN. IEEE makes it mean NaN. DX9 behavior is 0. I added a flag to be used by
st/nine to enable the DX9 behavior optionally, but leave the IEEE behavior for
GLSL. (There was some additional desire to expose that in a GL ext for WINE to
use, but it got shot down pretty quickly.)

Perhaps there are other changes from using the IEEE instruction variants, e.g.
denorms, which would be undesirable. I was never too familiar with the R600
ISA.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2592 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-11-04  3:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 12:39 [Bug 103544] Graphical glitches r600 in game this war of mine linux native bugzilla-daemon
2017-11-02 13:27 ` bugzilla-daemon
2017-11-02 13:36 ` bugzilla-daemon
2017-11-02 14:01 ` bugzilla-daemon
2017-11-03 15:48 ` bugzilla-daemon
2017-11-04  2:48 ` bugzilla-daemon
2017-11-04  3:21 ` bugzilla-daemon [this message]
2017-11-04  6:00 ` bugzilla-daemon
2017-11-04 14:34 ` bugzilla-daemon
2017-11-04 14:49 ` bugzilla-daemon
2017-11-06  4:52 ` bugzilla-daemon
2017-11-06 20:33 ` bugzilla-daemon
2017-11-06 21:14 ` bugzilla-daemon
2017-11-07 19:20 ` bugzilla-daemon
2017-11-08  0:25 ` bugzilla-daemon
2017-11-08  0:36 ` bugzilla-daemon
2017-11-15  2:22 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103544-502-WfaD90ucyS@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).