From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 103544] Graphical glitches r600 in game this war of mine linux native Date: Sat, 04 Nov 2017 03:21:39 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1349931508==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 92F5E6E151 for ; Sat, 4 Nov 2017 03:21:39 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1349931508== Content-Type: multipart/alternative; boundary="15097656991.a26195d.19688"; charset="UTF-8" --15097656991.a26195d.19688 Date: Sat, 4 Nov 2017 03:21:39 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D103544 --- Comment #6 from Ilia Mirkin --- (In reply to Roland Scheidegger from comment #5) > I've actually got that game myself here. > So I did the bisect and the winner is: > ce7a045feeef8cad155f1c9aa07f166e146e3d00 is the first bad commit > commit ce7a045feeef8cad155f1c9aa07f166e146e3d00 > Author: Ilia Mirkin > Date: Mon Jan 23 20:53:50 2017 -0500 >=20 > r600g: use ieee variants of multiplication instructions >=20=20=20=20=20 > This matches the behavior of most other drivers, including nouveau, > radeonsi, and i965. >=20=20=20=20=20 > Signed-off-by: Ilia Mirkin > Reviewed-by: Nicolai H=C3=A4hnle >=20 > Looks like some numerical issue then, albeit I don't know if the game is = at > fault here. Apologies for the trouble. The main difference between IEEE and non-IEEE is whether 0 * infinity =3D 0= or NaN. IEEE makes it mean NaN. DX9 behavior is 0. I added a flag to be used by st/nine to enable the DX9 behavior optionally, but leave the IEEE behavior = for GLSL. (There was some additional desire to expose that in a GL ext for WINE= to use, but it got shot down pretty quickly.) Perhaps there are other changes from using the IEEE instruction variants, e= .g. denorms, which would be undesirable. I was never too familiar with the R600 ISA. --=20 You are receiving this mail because: You are the assignee for the bug.= --15097656991.a26195d.19688 Date: Sat, 4 Nov 2017 03:21:39 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 6 on bug 10354= 4 from Ilia Mirkin
(In reply to Roland Scheidegger from comment #5)
> I've actually got that game myself here.
> So I did the bisect and the winner is:
> ce7a045feeef8cad155f1c9aa07f166e146e3d00 is the first bad commit
> commit ce7a045feeef8cad155f1c9aa07f166e146e3d00
> Author: Ilia Mirkin <im=
irkin@alum.mit.edu>
> Date:   Mon Jan 23 20:53:50 2017 -0500
>=20
>     r600g: use ieee variants of multiplication instructions
>=20=20=20=20=20
>     This matches the behavior of most other drivers, including nouveau,
>     radeonsi, and i965.
>=20=20=20=20=20
>     Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
>     Reviewed-by: Nicolai H=C3=A4hnle <nicolai.haehnle@amd.com>
>=20
> Looks like some numerical issue then, albeit I don't know if the game =
is at
> fault here.

Apologies for the trouble.

The main difference between IEEE and non-IEEE is whether 0 * infinity =3D 0=
 or
NaN. IEEE makes it mean NaN. DX9 behavior is 0. I added a flag to be used by
st/nine to enable the DX9 behavior optionally, but leave the IEEE behavior =
for
GLSL. (There was some additional desire to expose that in a GL ext for WINE=
 to
use, but it got shot down pretty quickly.)

Perhaps there are other changes from using the IEEE instruction variants, e=
.g.
denorms, which would be undesirable. I was never too familiar with the R600
ISA.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15097656991.a26195d.19688-- --===============1349931508== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1349931508==--