| Bug ID | 104275 |
|---|---|
| Summary | Stoney Ridge laptop display goes blank after HDMI gets plugge= d/unplugged in extended mode. |
| Product | DRI |
| Version | unspecified |
| Hardware | Other |
| OS | All |
| Status | NEW |
| Severity | normal |
| Priority | medium |
| Component | DRM/AMDgpu |
| Assignee | dri-devel@lists.freedesktop.org |
| Reporter | kai.heng.feng@canonical.com |
Hi, We are enabling a new Stoney Ridge laptop. The issue can be reproduced on branch drm-next-4.16-wip and amd-staging-drm-next. Reproduce steps: 1. Plug HDMI monitor. 2. Change to extended mode. 3. Unplug the HDMI monitor 4. Plug the HDMI monitor Internal display may go blank in step 3. The internal display may also go blank in step 4. The external one shows desktop correctly though. I can see lots of message flooding once I plugged HDMI: [ 120.933668] amdgpu 0000:00:01.0: 0000000030e07f1f pin failed [ 120.933859] [drm:amdgpu_crtc_page_flip_target [amdgpu]] *ERROR* failed to pin new abo buffer before flip These messages stop as soon as the HDMI is unplugged.
Created attachment 1=
36187 [details]
dmesg with drm.debug=3D0x0e
The fundamental issue here is that only 32 MB of memory are re= served as VRAM for the GPU. https://patchwo= rk.freedesktop.org/patch/192451/ should fix it (with DC enabled).
(In reply to Michel D=C3=A4nzer from comment #3) > The fundamental issue here is that only 32 MB of= memory are reserved as VRAM > for the GPU. >=20 > https://pa= tchwork.freedesktop.org/patch/192451/ should fix it (with DC > enabled). I applied both [1] and [2], also enabled DC for it, now the Unity Desktop is garbled. Unity Greeter in LightDM is fine though. [1] https://pat= chwork.freedesktop.org/patch/192451/ [2] https://pat= chwork.freedesktop.org/patch/192450/
Created attachment 136191 <=
a href=3D"attachment.cgi?id=3D136191&action=3Dedit" title=3D"Garbled di=
splay.">[details]
Garbled display.
| What | Removed | Added |
|---|---|---|
| CC | ckoenig.leichtzumerken@gmail.com |
Hmm, maybe a separate DC patch is needed as well. Christian?
Hi Michel, Before the buffer been pined to a location, can the buffer be moved to ot= her place? My opinion, this is not about VRAM size, it is the mechanism of buff= er move. Is this buffer content of rendering output or source or it is GPU com= mand buffer? Is there any better way we can narrow down or investigate?
(In reply to Alex_Zhang1 from comment #7) Without the patch referenced in com= ment 3, a buffer must be pinned to VRAM before it can be scanned out (displayed). The problem described in this rep= ort happens because pinning to VRAM fails, because there isn't enough space in VRAM. The patch allows buffers to be pinned to GTT instead of VRAM for scan= out. Another DC patch is probably needed to fix the garbled display described in comment 4. Maybe try the patch = on top of the amd-staging-drm-next branch.
Created attachment 13632= 1 [details] [review] DC scatter gather patch You'll need this DC patch.
Hi Harry, I'm wondering if there is also an equivalence method to fix it on v4.13 ker= nel.
(In reply to Harry Wentland from comment #9) > Created at= tachment 136321 [details] [review]= [review] > DC scatter gather patch >=20 > You'll need this DC patch. Hi Harry, As patch below, + /* + * TODO debug why this doesn't work on Raven + */ + if (adev->flags & AMD_IS_APU && + adev->asic_type >=3D CHIP_CARRIZO && + adev->asic_type < CHIP_RAVEN) + init_data.flags.gpu_vm_support =3D true; Seems this is just for debug, if I am wrong, please correct me. Do the fl= ags gpu_vm_support has support on 4.13 kernel? Could you please help to confirm= if this patch can be used on 4.13 kernel? Thanks
(In reply to Harry Wentland from comment #9) > Created at= tachment 136321 [details] [review]= [review] > DC scatter gather patch >=20 > You'll need this DC patch. I can confirm that the issue is fixed by this patch (with the additional two patches above). Thanks.
(In reply to AceLan Kao from comment #10) > Hi Harry, >=20 > I'm wondering if there is also an equivalence method to fix it on v4.13 > kernel. You could try applying the patches mentioned by Michel, plus my patch. I'm = not sure whether they'll apply well or work. The DC patch shouldn't be a proble= m if it applies but I'm not sure about the other patches Michel mentioned.
| What | Removed | Added |
|---|---|---|
| Status | NEW | RESOLVED |
| Resolution | --- | FIXED |