From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 104602] [apitrace] Graphical artifacts in Civilization VI on RX Vega Date: Thu, 01 Aug 2019 14:09:56 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0270515758==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 865656E63C for ; Thu, 1 Aug 2019 14:09:56 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0270515758== Content-Type: multipart/alternative; boundary="15646685966.db5AEeAC.6625" Content-Transfer-Encoding: 7bit --15646685966.db5AEeAC.6625 Date: Thu, 1 Aug 2019 14:09:56 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D104602 --- Comment #20 from Connor Abbott --- I wanted to make sure that improving the NIR path to reach parity with TGSI= in local variable handling wouldn't break things, so I investigated this a bit more. It seems this is triggered by the fact that on Vega the TGSI path alw= ays uses scratch, even for smaller local arrays. This bloats the scratch space = used by the VS in question. There are three back-to-back draw calls with this VS (used to build up the map), each using scratch, and it seems that radeonsi doesn't properly wait for each call to be done before starting the next and reuses the same scratch buffer, resulting in the threads from one draw call overwriting the scratch of the previous call. Hacking si_update_spi_tmpring_size() to always allocate a new scratch buffer "fixes" the black triangles. --=20 You are receiving this mail because: You are the assignee for the bug.= --15646685966.db5AEeAC.6625 Date: Thu, 1 Aug 2019 14:09:56 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 20 on bug 10460= 2 from Connor Abbott 
I wanted to make sure that improving the NIR path to reach par=
ity with TGSI in
local variable handling wouldn't break things, so I investigated this a bit
more. It seems this is triggered by the fact that on Vega the TGSI path alw=
ays
uses scratch, even for smaller local arrays. This bloats the scratch space =
used
by the VS in question. There are three back-to-back draw calls with this VS
(used to build up the map), each using scratch, and it seems that radeonsi
doesn't properly wait for each call to be done before starting the next and
reuses the same scratch buffer, resulting in the threads from one draw call
overwriting the scratch of the previous call. Hacking
si_update_spi_tmpring_size() to always allocate a new scratch buffer "=
fixes"
the black triangles.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15646685966.db5AEeAC.6625-- --===============0270515758== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0270515758==--