From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 105145] vaExportSurfaceHandle interaction with surface interlaced flag prevents switching on vaapi deinterlacing dynamically Date: Tue, 20 Feb 2018 14:23:06 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1799985473==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id D4A6F6E440 for ; Tue, 20 Feb 2018 14:23:05 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1799985473== Content-Type: multipart/alternative; boundary="15191365850.A75c9.8527" Content-Transfer-Encoding: 7bit --15191365850.A75c9.8527 Date: Tue, 20 Feb 2018 14:23:05 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D105145 --- Comment #8 from Christian K=C3=B6nig = --- (In reply to k.philipp from comment #7) > I did think about that, but it has the problem of breaking deinterlacing = on > all clients that do *not* set VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ (whic= h I > assume to be most) since there is - correct me if I'm wrong - at present = no > code to un-weave a decoded frame to fields and go back to interlaced/field > mode, causing the initial issue in the first place. Yeah, we can't do this without at least adding this frame to field conversi= on. How about VA_SURFACE_ATTRIB_USAGE_HINT_EXPORT then? The VA-API hints seem to describe the use case instead of the effect, so that would match. > > Now you just need to find somebody volunteering to implement that :) > Using the hint like in your proposal sounds doable to me because it's just > shuffling some code around, but if we have to add de-weaving (is that eve= n a > word?) I'm probably out. Actually not so much of a problem, IIRC we have code for this in the OMX st= ate tracker you could just copy&paste. Basically you allocate a new video buffer and then copy from (0,0)-(width, heigth-1) to the top field and (0,1)-(width,height) to the bottom field of = the new buffer using the blitter function. Since the blitter uses nearest pixel interpolation that should slit the fra= me into two fields. I can search for the code if you're interested. --=20 You are receiving this mail because: You are the assignee for the bug.= --15191365850.A75c9.8527 Date: Tue, 20 Feb 2018 14:23:05 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 8 on bug 10514= 5 from Christian K=C3= =B6nig
(In reply to k.philipp from comment #7)
> I did think about that, but it has the problem o=
f breaking deinterlacing on
> all clients that do *not* set VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ (w=
hich I
> assume to be most) since there is - correct me if I'm wrong - at prese=
nt no
> code to un-weave a decoded frame to fields and go back to interlaced/f=
ield
> mode, causing the initial issue in the first place.

Yeah, we can't do this without at least adding this frame to field conversi=
on.

How about VA_SURFACE_ATTRIB_USAGE_HINT_EXPORT then? The VA-API hints seem to
describe the use case instead of the effect, so that would match.

> > Now you just need to find somebody voluntee=
ring to implement that :)
> Using the hint like in your proposal sounds doable to me because it's =
just
> shuffling some code around, but if we have to add de-weaving (is that =
even a
> word?) I'm probably out.

Actually not so much of a problem, IIRC we have code for this in the OMX st=
ate
tracker you could just copy&paste.

Basically you allocate a new video buffer and then copy from (0,0)-(width,
heigth-1) to the top field and (0,1)-(width,height) to the bottom field of =
the
new buffer using the blitter function.

Since the blitter uses nearest pixel interpolation that should slit the fra=
me
into two fields. I can search for the code if you're interested.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15191365850.A75c9.8527-- --===============1799985473== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1799985473==--