From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 105145] vaExportSurfaceHandle interaction with surface
interlaced flag prevents switching on vaapi deinterlacing dynamically
Date: Tue, 20 Feb 2018 11:55:18 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1285679514=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id AAB266E3B5
for ; Tue, 20 Feb 2018 11:55:18 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============1285679514==
Content-Type: multipart/alternative; boundary="15191277180.77Aa2.8288"
Content-Transfer-Encoding: 7bit
--15191277180.77Aa2.8288
Date: Tue, 20 Feb 2018 11:55:18 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D105145
--- Comment #5 from k.philipp@gmail.com ---
(In reply to Christian K=C3=B6nig from comment #4)
> (In reply to k.philipp from comment #3)
> > Also, that VAAPI has to weave the first few textures before they've been
> > exported once is not very nice. Is there some kind of hint we could giv=
e the
> > driver that we want to have progressive surfaces?
>=20
> Not that I know of, but feel free to suggest something.
There are some surface hints, but I'm not sure if they fit this use case. Y=
ou
could argue that VA_SURFACE_ATTRIB_USAGE_HINT_DISPLAY ("Surface used for
display") kind of applies here, since to display you have to export and to
export you have to have it as frame (both for vaDeriveImage and
vaExportSurfaceHandle). But yeah, there's also the third way of using
vaPutSurface or vaGetSurfaceBufferWl (in theory, not sure how well mesa
supports it) which would not inherently be limited to working with frames.
"used for display" does not seem very well-defined in either case, so we co=
uld
get away with it.
Cleaner solution could be to think of something new, of course. Something l=
ike
VA_SURFACE_ATTRIB_USAGE_HINT_EXPORT_AS_FRAME? It really depends on what most
accurately describes what info mesa needs.
If we agree on a name, I can try to bring it up with the libva people.
> General problem with
> VA-API seems to be that suggestions made by AMD seems to be mostly ignore=
d.
That sounds very unfortunate. To be fair, I think that the TOP/BOTTOM field
flags would have been added if this was raised during the vaExportSurfaceHa=
ndle
discussion (https://github.com/intel/libva/pull/125) - maybe it was raised
somewhere else, then please forgive my ignorance :-) It was my understanding
that the addition of vaExportSurfaceHandle was done at least in part to be =
able
to support VA-API in a usable fashion on AMD hardware at all.
>=20
> Also don't call it interlaced/progressive (that was just me trying to make
> sense of what the hardware is doing).
>=20
> Instead call it something in the line of FIELD and FRAME, that is the more
> common terminology at least in the different MPEG standards.
OK!
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15191277180.77Aa2.8288
Date: Tue, 20 Feb 2018 11:55:18 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Commen=
t # 5
on bug 10514=
5
from k.philipp@gm=
ail.com
(In reply to Christian K=C3=B6nig from comment #4)
> (In reply to k.philipp from comment #3)
> > Also, that VAAPI has to weave the first few textures before they'=
ve been
> > exported once is not very nice. Is there some kind of hint we cou=
ld give the
> > driver that we want to have progressive surfaces?
>=20
> Not that I know of, but feel free to suggest something.
There are some surface hints, but I'm not sure if they fit this use case. Y=
ou
could argue that VA_SURFACE_ATTRIB_USAGE_HINT_DISPLAY ("Surface used f=
or
display") kind of applies here, since to display you have to export an=
d to
export you have to have it as frame (both for vaDeriveImage and
vaExportSurfaceHandle). But yeah, there's also the third way of using
vaPutSurface or vaGetSurfaceBufferWl (in theory, not sure how well mesa
supports it) which would not inherently be limited to working with frames.
"used for display" does not seem very well-defined in either case=
, so we could
get away with it.
Cleaner solution could be to think of something new, of course. Something l=
ike
VA_SURFACE_ATTRIB_USAGE_HINT_EXPORT_AS_FRAME? It really depends on what most
accurately describes what info mesa needs.
If we agree on a name, I can try to bring it up with the libva people.
> General problem with
> VA-API seems to be that suggestions made by AMD seems to be mostly ign=
ored.
That sounds very unfortunate. To be fair, I think that the TOP/BOTTOM field
flags would have been added if this was raised during the vaExportSurfaceHa=
ndle
discussion (https://git=
hub.com/intel/libva/pull/125) - maybe it was raised
somewhere else, then please forgive my ignorance :-) It was my understanding
that the addition of vaExportSurfaceHandle was done at least in part to be =
able
to support VA-API in a usable fashion on AMD hardware at all.
>=20
> Also don't call it interlaced/progressive (that was just me trying to =
make
> sense of what the hardware is doing).
>=20
> Instead call it something in the line of FIELD and FRAME, that is the =
more
> common terminology at least in the different MPEG standards.
OK!
You are receiving this mail because:
- You are the assignee for the bug.
=
--15191277180.77Aa2.8288--
--===============1285679514==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============1285679514==--