From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 105145] vaExportSurfaceHandle interaction with surface interlaced flag prevents switching on vaapi deinterlacing dynamically Date: Tue, 20 Feb 2018 13:51:15 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1196426577==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 357C46E42C for ; Tue, 20 Feb 2018 13:51:15 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1196426577== Content-Type: multipart/alternative; boundary="15191346751.53b649b.31046" Content-Transfer-Encoding: 7bit --15191346751.53b649b.31046 Date: Tue, 20 Feb 2018 13:51:15 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D105145 --- Comment #7 from k.philipp@gmail.com --- (In reply to Christian K=C3=B6nig from comment #6) > But checking the documentation once more > VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ actually sounds exactly like what we > need. >=20 > E.g. we switch over to allocate all surfaces in the progressive/frame for= mat > and only use the interlaced/field format when > VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ is given. I did think about that, but it has the problem of breaking deinterlacing on= all clients that do *not* set VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ (which I as= sume to be most) since there is - correct me if I'm wrong - at present no code to un-weave a decoded frame to fields and go back to interlaced/field mode, causing the initial issue in the first place. > Now you just need to find somebody volunteering to implement that :) Using the hint like in your proposal sounds doable to me because it's just shuffling some code around, but if we have to add de-weaving (is that even a word?) I'm probably out. --=20 You are receiving this mail because: You are the assignee for the bug.= --15191346751.53b649b.31046 Date: Tue, 20 Feb 2018 13:51:15 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 7 on bug 10514= 5 from k.philipp@gm= ail.com 
(In reply to Christian K=C3=B6nig from comment #6)
> But checking the documentation once more
> VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ actually sounds exactly like wha=
t we
> need.
>=20
> E.g. we switch over to allocate all surfaces in the progressive/frame =
format
> and only use the interlaced/field format when
> VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ is given.
I did think about that, but it has the problem of breaking deinterlacing on=
 all
clients that do *not* set VA_SURFACE_ATTRIB_USAGE_HINT_VPP_READ (which I as=
sume
to be most) since there is - correct me if I'm wrong - at present no code to
un-weave a decoded frame to fields and go back to interlaced/field mode,
causing the initial issue in the first place.

> Now you just need to find somebody volunteering =
to implement that :)
Using the hint like in your proposal sounds doable to me because it's just
shuffling some code around, but if we have to add de-weaving (is that even a
word?) I'm probably out.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15191346751.53b649b.31046-- --===============1196426577== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1196426577==--