dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows.
@ 2018-02-27 23:55 bugzilla-daemon
  2018-02-27 23:56 ` bugzilla-daemon
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: bugzilla-daemon @ 2018-02-27 23:55 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 1305 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=105282

            Bug ID: 105282
           Summary: Divinity: Original Sin Enhanced Edition blocky and
                    jagged shadows.
           Product: Mesa
           Version: 17.3
          Hardware: All
                OS: Linux (All)
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: e.singularitycat@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

After working around the bugs described in #93551 and getting the game running,
I noticed that unless the shadow quality setting was at "Ultra", all rendered
shadows are blocky and jagged, with gaps appearing between the shadows cast be
apparently solid objects.

I messed around with some driconf options, and discovered that this rendering
issue goes away if setting the "glsl_correct_derivatives_after_discard" option.

Unfortunately, I couldn't get a working apitrace because of the LD_PRELOAD
hacks, but attached are two screenshots of roughly the same area, one without
the option (before.png) and one with (after.png).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2695 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows.
  2018-02-27 23:55 [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows bugzilla-daemon
@ 2018-02-27 23:56 ` bugzilla-daemon
  2018-02-27 23:57 ` bugzilla-daemon
  2019-08-05  5:36 ` bugzilla-daemon
  2 siblings, 0 replies; 4+ messages in thread
From: bugzilla-daemon @ 2018-02-27 23:56 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 351 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=105282

--- Comment #1 from Elliot Thomas <e.singularitycat@gmail.com> ---
Created attachment 137676
  --> https://bugs.freedesktop.org/attachment.cgi?id=137676&action=edit
Without "glsl_correct_derivatives_after_discard"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1394 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows.
  2018-02-27 23:55 [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows bugzilla-daemon
  2018-02-27 23:56 ` bugzilla-daemon
@ 2018-02-27 23:57 ` bugzilla-daemon
  2019-08-05  5:36 ` bugzilla-daemon
  2 siblings, 0 replies; 4+ messages in thread
From: bugzilla-daemon @ 2018-02-27 23:57 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 348 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=105282

--- Comment #2 from Elliot Thomas <e.singularitycat@gmail.com> ---
Created attachment 137677
  --> https://bugs.freedesktop.org/attachment.cgi?id=137677&action=edit
With "glsl_correct_derivatives_after_discard"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1385 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows.
  2018-02-27 23:55 [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows bugzilla-daemon
  2018-02-27 23:56 ` bugzilla-daemon
  2018-02-27 23:57 ` bugzilla-daemon
@ 2019-08-05  5:36 ` bugzilla-daemon
  2 siblings, 0 replies; 4+ messages in thread
From: bugzilla-daemon @ 2019-08-05  5:36 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 964 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=105282

Timothy Arceri <t_arceri@yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Timothy Arceri <t_arceri@yahoo.com.au> ---
Should be fixed by:

commit 3c9144f9e5888e9a31886b64168f63e991da01d0
Author: Timothy Arceri <tarceri@itsqueeze.com>
Date:   Fri Aug 2 10:05:20 2019 +1000

    drirc: Add discard workaround for Divinity: Original Sin EE

    This adds an additional work around for the game to fix the blocky
    shadows as reported in bug 105282

    Acked-by: Eric Engestrom <eric.engestrom@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105282

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3038 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-05  5:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-27 23:55 [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows bugzilla-daemon
2018-02-27 23:56 ` bugzilla-daemon
2018-02-27 23:57 ` bugzilla-daemon
2019-08-05  5:36 ` bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).