From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows Date: Thu, 22 Nov 2018 16:09:37 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1603984649==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 50BFC6E110 for ; Thu, 22 Nov 2018 16:09:37 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1603984649== Content-Type: multipart/alternative; boundary="15429029771.FA0FDe0.28949" Content-Transfer-Encoding: 7bit --15429029771.FA0FDe0.28949 Date: Thu, 22 Nov 2018 16:09:37 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D106175 --- Comment #60 from Brandon Wright --- > There are larger problems within amdgpu_dm's commit tail that if addresse= d=20 > should resolve this issue for compton I'd imagine. Honestly, I don't care about compton. I don't think you realize the effects= of this issue. It seriously affects performance when the cursor is in motion w= ith any page-flipping application. GNOME and KDE, while the window motion is le= ss affected, stutter in composited client applications.=20 > This is a nice attempt but it only resolves the problem because it relies= on > the blocking behavior in atomic check that amdgpu_dm currently does=20 > (and shouldn't be doing). > > Asynchronous updates can and will occur in parallel with other commits on= =20 > worker threads. Without the wait in atomic_check you'll see the IGT legac= y=20 > cursor tests break with this patch (and there will probably be system fau= lts=20 > as well). You'd have to point this out to me, because I didn't see anything that would obviously block, unless it's buried in dc_validate_plane. Since, as you say, atomic_check is blocking for now, why not work around th= is issue with a tiny change. If someone ever gets around to doing things the correct way it's no big deal to remove. --=20 You are receiving this mail because: You are the assignee for the bug.= --15429029771.FA0FDe0.28949 Date: Thu, 22 Nov 2018 16:09:37 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 60 on bug 10617= 5 from Brandon Wright
> There are larger problems within am=
dgpu_dm's commit tail that if addressed=20
> should resolve this issue for compton I'd imagine.
Honestly, I don't care about compton. I don't think you realize the effects=
 of
this issue. It seriously affects performance when the cursor is in motion w=
ith
any page-flipping application. GNOME and KDE, while the window motion is le=
ss
affected, stutter in composited client applications.=20

> This is a nice attempt but it only resolves the =
problem because it relies on
> the blocking behavior in atomic check that amdgpu_dm currently does=20
> (and shouldn't be doing).
>
> Asynchronous updates can and will occur in paral=
lel with other commits on=20
> worker threads. Without the wait in atomic_check you'll see the IGT le=
gacy=20
> cursor tests break with this patch (and there will probably be system =
faults=20
> as well).
You'd have to point this out to me, because I didn't see anything that would
obviously block, unless it's buried in dc_validate_plane.

Since, as you say, atomic_check is blocking for now, why not work around th=
is
issue with a tiny change. If someone ever gets around to doing things the
correct way it's no big deal to remove.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15429029771.FA0FDe0.28949-- --===============1603984649== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1603984649==--