From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows Date: Thu, 22 Nov 2018 21:00:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0361529759==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E36B6E3C2 for ; Thu, 22 Nov 2018 21:00:31 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0361529759== Content-Type: multipart/alternative; boundary="15429204314.0FcF34dD.8313" Content-Transfer-Encoding: 7bit --15429204314.0FcF34dD.8313 Date: Thu, 22 Nov 2018 21:00:31 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D106175 --- Comment #65 from bmilreu@gmail.com --- (In reply to Nicholas Kazlauskas from comment #64) > Created attachment 142574 [details] [review] > 0001-drm-amd-display-Add-fast-path-for-legacy-cursor-plan.patch >=20 > This patch is similar to the async_update one but it takes care to lock if > anything is modifying the plane. It's very close to what i915 does with a > few minor differences with framebuffer handling. >=20 > I've tested it for compton with Gallium HUD up and I no longer see the is= sue > on mouse movement (cursor fb changes are still a bit slow, so you'll still > probably see spikes on cursor changes). >=20 > You can try this on top of amd-staging-drm-next and I'd imagine it'd fix > your problems. Patch does work for me. Is there an easy way to backport this to 4.19 mainline? Would be very usefu= l to integrate the fix into stable kernels. As it is currently it wont work on 4.19 because it uses which isnt mainlined yet. Brandon's hack works on 4.19 just in case it matt= ers. Last question, is this patch https://patchwork.freedesktop.org/patch/263412/ you just submitted related to this issue?=20 Thanks a LOT for tackling this Nicholas and Brandon --=20 You are receiving this mail because: You are the assignee for the bug.= --15429204314.0FcF34dD.8313 Date: Thu, 22 Nov 2018 21:00:31 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 65 on bug 10617= 5 from bmilreu@gmail.co= m
(In reply to Nicholas Kazlauskas from comment #64)
> Created attachment 142574 [details] [review=
] [review]
> 0001-drm-amd-display-Add-fast-path-for-legacy-cursor-plan.patch
>=20
> This patch is similar to the async_update one but it takes care to loc=
k if
> anything is modifying the plane. It's very close to what i915 does wit=
h a
> few minor differences with framebuffer handling.
>=20
> I've tested it for compton with Gallium HUD up and I no longer see the=
 issue
> on mouse movement (cursor fb changes are still a bit slow, so you'll s=
till
> probably see spikes on cursor changes).
>=20
> You can try this on top of amd-staging-drm-next and I'd imagine it'd f=
ix
> your problems.

Patch does work for me.

Is there an easy way to backport this to 4.19 mainline? Would be very usefu=
l to
integrate the fix into stable kernels.

As it is currently it wont work on 4.19 because it uses <drm/drm_atomic_=
uapi.h>
which isnt mainlined yet. Brandon's hack works on 4.19 just in case it matt=
ers.

Last question, is this patch https://patchwork.freedesktop.org/patch/263412/
you just submitted related to this issue?=20

Thanks a LOT for tackling this Nicholas and Brandon


You are receiving this mail because:
  • You are the assignee for the bug.
= --15429204314.0FcF34dD.8313-- --===============0361529759== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0361529759==--