Comme=
nt # 59
on bug 10617=
5
from bmilreu@gmail.co=
m
(In reply to Nicholas Kazlauskas from comment #58)
> (In reply to Brandon Wright from comment #55)
> > Created a=
ttachment 142558 [details]=
[review] [review] [review]
> > Patch that "fixes" the problem.
> >=20
> > I've attached a patch that fixes the problem for me. It copies pa=
rts from
> > the intel patch and uses the existing async infrastructure for th=
e cursor.=20
> >=20
> > It's really tiny, so I hope this is helpful enough to get this pr=
oblem fixed
> > quick.
>=20
> This is a nice attempt but it only resolves the problem because it rel=
ies on
> the blocking behavior in atomic check that amdgpu_dm currently does (a=
nd
> shouldn't be doing).
>=20
> Asynchronous updates can and will occur in parallel with other commits=
on
> worker threads. Without the wait in atomic_check you'll see the IGT le=
gacy
> cursor tests break with this patch (and there will probably be system =
faults
> as well).
>=20
> There are larger problems within amdgpu_dm's commit tail that if addre=
ssed
> should resolve this issue for compton I'd imagine.
Since you've been working on Freesync, you should know your patches are also
affected by this bug on some wine games. Any chance you could you kindly tr=
y to
tackle this?=20
btw, I don't have igt on my system atm, nor got any system fault yet with t=
he
patch. I really need dc for the extra headphone jack, mine is broken atm :(=