From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 106175] amdgpu.dc=1 shows performance issues with Xorg compositors when moving windows Date: Thu, 22 Nov 2018 14:32:55 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1380727895==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id D5F716E52A for ; Thu, 22 Nov 2018 14:32:55 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1380727895== Content-Type: multipart/alternative; boundary="15428971754.2E28E215.24923" Content-Transfer-Encoding: 7bit --15428971754.2E28E215.24923 Date: Thu, 22 Nov 2018 14:32:55 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D106175 --- Comment #58 from Nicholas Kazlauskas --- (In reply to Brandon Wright from comment #55) > Created attachment 142558 [details] [review] > Patch that "fixes" the problem. >=20 > I've attached a patch that fixes the problem for me. It copies parts from > the intel patch and uses the existing async infrastructure for the cursor= .=20 >=20 > It's really tiny, so I hope this is helpful enough to get this problem fi= xed > quick. This is a nice attempt but it only resolves the problem because it relies on the blocking behavior in atomic check that amdgpu_dm currently does (and shouldn't be doing). Asynchronous updates can and will occur in parallel with other commits on worker threads. Without the wait in atomic_check you'll see the IGT legacy cursor tests break with this patch (and there will probably be system fault= s as well). There are larger problems within amdgpu_dm's commit tail that if addressed should resolve this issue for compton I'd imagine. --=20 You are receiving this mail because: You are the assignee for the bug.= --15428971754.2E28E215.24923 Date: Thu, 22 Nov 2018 14:32:55 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 58 on bug 10617= 5 from Nicholas Kazlauskas<= /a> 
(In reply to Brandon Wright from comment #55)
> Created attachment 142558 [de=
tails] [review] [review]
> Patch that "fixes" the problem.
>=20
> I've attached a patch that fixes the problem for me. It copies parts f=
rom
> the intel patch and uses the existing async infrastructure for the cur=
sor.=20
>=20
> It's really tiny, so I hope this is helpful enough to get this problem=
 fixed
> quick.

This is a nice attempt but it only resolves the problem because it relies on
the blocking behavior in atomic check that amdgpu_dm currently does (and
shouldn't be doing).

Asynchronous updates can and will occur in parallel with other commits on
worker threads. Without the wait in atomic_check you'll see the IGT legacy
cursor tests break with this patch (and there will probably be system fault=
s as
well).

There are larger problems within amdgpu_dm's commit tail that if addressed
should resolve this issue for compton I'd imagine.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15428971754.2E28E215.24923-- --===============1380727895== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1380727895==--