From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 106258] AMD Xorg start failes with non-4K page sizes Date: Thu, 21 Jun 2018 10:22:02 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1055425758==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id A8FF36E776 for ; Thu, 21 Jun 2018 10:22:02 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1055425758== Content-Type: multipart/alternative; boundary="15295765221.0aeC3.8956" Content-Transfer-Encoding: 7bit --15295765221.0aeC3.8956 Date: Thu, 21 Jun 2018 10:22:02 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D106258 --- Comment #36 from foxbat@ruin.net --- (In reply to Michel D=C3=A4nzer from comment #35) > Created attachment 140257 [details] [review] > drm/amdgpu: GPU vs CPU page size fixes in amdgpu_vm_bo_split_mapping >=20 > Does this patch help? It looks like the patch isn't fully applying (using tree 4.17): patching file drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c Hunk #1 FAILED at 1577. Hunk #2 succeeded at 1463 with fuzz 2 (offset -127 lines). Hunk #3 succeeded at 1480 (offset -125 lines). 1 out of 3 hunks FAILED -- saving rejects to file drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c.rej rejects: --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -1577,7 +1577,9 @@ static int amdgpu_vm_bo_split_mapping(struct amdgpu_device *adev, uint64_t count; max_entries =3D min(max_entries, 16ull * 1024ull); - for (count =3D 1; count < max_entries; ++count) { + for (count =3D 1; + count < max_entries / (PAGE_SIZE / AMDGPU_GPU_PAGE_SIZE); + ++count) { uint64_t idx =3D pfn + count; if (pages_addr[idx] !=3D --=20 You are receiving this mail because: You are the assignee for the bug.= --15295765221.0aeC3.8956 Date: Thu, 21 Jun 2018 10:22:02 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 36 on bug 10625= 8 from foxbat@ruin.net 
(In reply to Michel D=C3=A4nzer from comment #35)
> Created attachment 140257 [details]=
 [review] [review]
> drm/amdgpu: GPU vs CPU page size fixes in  amdgpu_vm_bo_split_mapping
>=20
> Does this patch help?

It looks like the patch isn't fully applying (using tree 4.17):

patching file drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
Hunk #1 FAILED at 1577.
Hunk #2 succeeded at 1463 with fuzz 2 (offset -127 lines).
Hunk #3 succeeded at 1480 (offset -125 lines).
1 out of 3 hunks FAILED -- saving rejects to file
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c.rej

rejects:

--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -1577,7 +1577,9 @@ static int amdgpu_vm_bo_split_mapping=
(struct
amdgpu_device *adev,
                        uint64_t count;

                        max_entries =3D min(max_entries, 16ull * 1024ull);
-                       for (count =3D 1; count < max_entries; ++count) {
+                       for (count =3D 1;
+                            count < max_entries / (PAGE_SIZE /
AMDGPU_GPU_PAGE_SIZE);
+                            ++count) {
                                uint64_t idx =3D pfn + count;

                                if (pages_addr[idx] !=3D

You are receiving this mail because:
  • You are the assignee for the bug.
= --15295765221.0aeC3.8956-- --===============1055425758== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1055425758==--