[Bug 106306] amdgpu CIK power management issues (wattman)

[Bug 106306] amdgpu CIK power management issues (wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1207 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

            Bug ID: 106306
           Summary: amdgpu CIK power management issues (wattman)
           Product: DRI
           Version: DRI git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: grmat@sub.red

Created attachment 139211
  --> https://bugs.freedesktop.org/attachment.cgi?id=139211&action=edit
dmesg output pp_num_states

Testing upstream kernel (4.17.0-rc2-ga27fc14219f2) because of the newly
introduced "wattman" functionality. On my CIK hardware (Hawaii/R9 290X), none
of the sysfs and hwmon entries work. Writing to sysfs files like pp_sclk_od,
pp_od_clk_voltage works (no error) but the hardware/driver does not react to
the changes. Reading sysfs/hwmon files like power1_cap_max, pp_table,
pp_od_clk_voltage print no output. Trying to read from pp_num_states even
segfaults (attached is the dmesg output of the corresponding error).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2653 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 502 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

grmat@sub.red changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|amdgpu CIK power management |amdgpu CIK power management
                   |issues (wattman)            |issues (overdrive and
                   |                            |wattman)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1109 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 571 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

--- Comment #1 from grmat@sub.red ---
Overdrive doesn't work either with current stable kernel (4.16.6). Clock
remains stable (as seen in amdgpu_pm_info) and reading the value gives 0:

> echo 5 | sudo tee /sys/class/drm/card0/device/pp_sclk_od
5
> cat /sys/class/drm/card0/device/pp_sclk_od
0

I can't currently tell when this issue appeared or if the feature even ever
worked with this hardware, as I've never been using it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1402 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 418 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

--- Comment #2 from Alex Deucher <alexdeucher@gmail.com> ---
CI parts default to the legacy dpm support, you need to enable powerplay to use
the new APIs.  Boot with amdgpu.dpm=1 on the kernel command line in grub to
force the driver to use powerplay rather than the old dpm code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 694 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

--- Comment #3 from grmat@sub.red ---
Thanks, I wasn't aware of that.

The old overdrive functionality indeed works with amdgpu.dpm=1 on 4.16.
However, it doesn't on 4.17. And wattman functionality doesn't work at all;
pp_od_clk_voltage prints nothing and doesn't accept anything. Is wattman even
implemented for CI?

Also, do you consider enabling amdgpu.dpm for CI by default? I found the big
advantage that the VRAM/MC is finally back to the lower dpm state in idle while
driving a WQHD 144 Hz monitor. That saves solid 40 Watts on desktop usage.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1463 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 499 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

--- Comment #4 from grmat@sub.red ---
> wattman functionality doesn't work at all;
> pp_od_clk_voltage prints nothing and doesn't accept anything. Is wattman
> even implemented for CI?

@Alex Deucher: Currently on 4.17.3 w/ dpm and the situation hasn't changed. Is
the wattman functionality supposed to work with CIK or not? Do you need any
additional info?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1309 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 587 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

--- Comment #5 from Alex Deucher <alexdeucher@gmail.com> ---
You need to make sure the PP_OVERDRIVE_MASK flag (bit 14) is set.  E.g.,
amdgpu.ppfeaturemask=0xfffd7fff
See the documentation in the driver for more:
https://cgit.freedesktop.org/~agd5f/linux/tree/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c?h=amd-staging-drm-next#n469
Also, If the vbios on the particular board does not support overclocking, the
functionality is not exposed on 4.17 IIRC.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1518 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 271 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

--- Comment #6 from Alex Deucher <alexdeucher@gmail.com> ---
Append amdgpu.ppfeaturemask=0xfffd7fff to the kernel command line in grub.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1074 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

--- Comment #7 from grmat@sub.red ---
Thank you for your answer.

I've already set the ppfeaturemask accordingly.

cat /sys/class/drm/card0/device/pp_od_clk_voltage

returns nothing and 

[root] echo "s 7 1000 1200" > /sys/class/drm/card0/device/pp_od_clk_voltage

prints "Invalid argument"

at the time of trying to write to the file, the following is put to the kernel
ring buffer:

amdgpu: [powerplay] OverDrive feature not enabled

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1377 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106306] amdgpu CIK power management issues (overdrive and wattman)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 805 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106306

Martin Peres <martin.peres@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #8 from Martin Peres <martin.peres@free.fr> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/369.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2398 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel