dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 106928] When starting a match Rocket League crashes on "Go"
Date: Fri, 07 Sep 2018 17:36:24 +0000	[thread overview]
Message-ID: <bug-106928-502-Uysr2xWZCd@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-106928-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1696 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106928

Andrés Gómez García <agomez@igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agomez@igalia.com,
                   |                            |sroland@vmware.com

--- Comment #21 from Andrés Gómez García <agomez@igalia.com> ---
Roland, is this fixed by?

commit 817efd89685efc6b5866e09cbdad01c4ff21c737
Author: Roland Scheidegger <sroland@vmware.com>
Date:   Wed Jul 4 04:44:17 2018 +0200

    r600/sb: fix crash in fold_alu_op3

    fold_assoc() called from fold_alu_op3() can lower the number of src to 2,
    which then leads to an invalid access to n.src[2]->gvalue().
    This didn't seem to have caused much harm in the past, but on Fedora 28
    it will crash (presumably because -D_GLIBCXX_ASSERTIONS is used, although
    with libstdc++ 4.8.5 this didn't do anything, -D_GLIBCXX_DEBUG was
    needed to show the issue).

    An alternative fix would be to instead call fold_alu_op2() from within
    fold_assoc() when the number of src is reduced and return always TRUE
    from fold_assoc() in this case, with the only actual difference being
    the return value from fold_alu_op3() then. I'm not sure what the return
    value actually should be in this case (or whether it even can make a
    difference).

    https://bugs.freedesktop.org/show_bug.cgi?id=106928
    Cc: mesa-stable@lists.freedesktop.org
    Reviewed-by: Dave Airlie <airlied@redhat.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3374 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-09-07 17:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 12:21 [Bug 106928] When starting a match Rocket League crashes on "Go" bugzilla-daemon
2018-06-15 12:59 ` bugzilla-daemon
2018-06-22 16:26 ` bugzilla-daemon
2018-06-26 15:50 ` bugzilla-daemon
2018-06-26 16:27 ` bugzilla-daemon
2018-06-26 22:16 ` bugzilla-daemon
2018-06-27  0:38 ` bugzilla-daemon
2018-06-28 18:06 ` bugzilla-daemon
2018-06-28 18:30 ` bugzilla-daemon
2018-06-29  0:09 ` bugzilla-daemon
2018-06-29  2:57 ` bugzilla-daemon
2018-06-29  7:16 ` bugzilla-daemon
2018-06-29 15:09 ` bugzilla-daemon
2018-06-29 19:09 ` bugzilla-daemon
2018-06-29 20:11 ` bugzilla-daemon
2018-06-29 20:23 ` bugzilla-daemon
2018-06-29 20:45 ` bugzilla-daemon
2018-06-29 20:54 ` bugzilla-daemon
2018-07-04  7:50 ` bugzilla-daemon
2018-07-10  7:57 ` bugzilla-daemon
2018-07-10  8:15 ` bugzilla-daemon
2018-09-07 17:36 ` bugzilla-daemon [this message]
2018-09-07 18:28 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106928-502-Uysr2xWZCd@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).