From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 107115] Make darktable OpenCL support work on Clover and RadeonSI Date: Wed, 04 Jul 2018 19:30:29 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0388144426==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D0706EC55 for ; Wed, 4 Jul 2018 19:30:29 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0388144426== Content-Type: multipart/alternative; boundary="15307326290.ecCEF7A6.25710" Content-Transfer-Encoding: 7bit --15307326290.ecCEF7A6.25710 Date: Wed, 4 Jul 2018 19:30:29 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D107115 Bug ID: 107115 Summary: Make darktable OpenCL support work on Clover and RadeonSI Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: FreeBSD Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: greg@unrelenting.technology QA Contact: dri-devel@lists.freedesktop.org Hi everyone, I've tried to get the darktable photo editor https://www.darktable.org to work, and there's more to it than image suppor= t... First, I've picked up funfunctor's patches (mentioned in bug 99553), they applied cleanly to master (except for the little one-line "=3D 1" since the r600/radeonsi split happened, but that was trivial to fix). My branch with = them is https://github.com/myfreeweb/mesa/tree/clover-image Second, there was some weird mismatch between libclc's headers and darktabl= e's code, and I've had to do: %s/write_only image2d_t/image2d_t and %s/__image2d_t/image2d_t on all files in PREFIX/share/darktable/kernels. Third, the liquify.cl kernel triggered the https://bugs.llvm.org/show_bug.cgi?id=3D36679 crash (which is fixed in llvm= 7... but I just removed the function body to proceed without this particular eff= ect) And finally, with all kernels compiled, darktable benchmarked CPU vs GPU and found the CPU to be a bit faster (yay for Ryzen) and disabled OpenCL usage. Enabling OpenCL usage in the settings and then double clicking on an image.= .. uhh... hard locked the GPU :D drmn0: GPU fault detected: 147 0x05004402 drmn0: VM_CONTEXT1_PROTECTION_FAULT_ADDR 0x005000A0 drmn0: VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x08044002 drmn0: VM fault (0x02, vmid 4) at page 5243040, read from 'TC5' (0x54433500) (68) P.S. system info: AMD Radeon RX 480, FreeBSD 12-CURRENT / drm-next-kmod 4.15 (DRM 3.23.0) with amdgpu.dc=3D1, LLVM 6.0.0, Mesa with patches on top of gi= t rev c2ae9b4052701, libclc git rev c45b9dfe5257, darktable 2.4.4. --=20 You are receiving this mail because: You are the assignee for the bug.= --15307326290.ecCEF7A6.25710 Date: Wed, 4 Jul 2018 19:30:29 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 107115
Summary Make darktable OpenCL support work on Clover and RadeonSI
Product Mesa
Version git
Hardware x86-64 (AMD64)
OS FreeBSD
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter greg@unrelenting.technology
QA Contact dri-devel@lists.freedesktop.org

Hi everyone, I've tried to get the darktable photo editor
https://www.darktable.org to work=
, and there's more to it than image support...

First, I've picked up funfunctor's patches (mentioned in bug 99553), they
applied cleanly to master (except for the little one-line "=3D 1"=
 since the
r600/radeonsi split happened, but that was trivial to fix). My branch with =
them
is https://=
github.com/myfreeweb/mesa/tree/clover-image

Second, there was some weird mismatch between libclc's headers and darktabl=
e's
code, and I've had to do:

%s/write_only image2d_t/image2d_t

and

%s/__image2d_t/image2d_t

on all files in PREFIX/share/darktable/kernels.

Third, the liquify.cl kernel triggered the
https://bugs.llvm=
.org/show_bug.cgi?id=3D36679 crash (which is fixed in llvm 7...
but I just removed the function body to proceed without this particular eff=
ect)

And finally, with all kernels compiled, darktable benchmarked CPU vs GPU and
found the CPU to be a bit faster (yay for Ryzen) and disabled OpenCL usage.

Enabling OpenCL usage in the settings and then double clicking on an image.=
..
uhh... hard locked the GPU :D

drmn0: GPU fault detected: 147 0x05004402
drmn0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR   0x005000A0
drmn0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS 0x08044002
drmn0: VM fault (0x02, vmid 4) at page 5243040, read from 'TC5' (0x54433500)
(68)

P.S. system info: AMD Radeon RX 480, FreeBSD 12-CURRENT / drm-next-kmod 4.15
(DRM 3.23.0) with amdgpu.dc=3D1, LLVM 6.0.0, Mesa with patches on top of gi=
t rev
c2ae9b4052701, libclc git rev c45b9dfe5257, darktable 2.4.4.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15307326290.ecCEF7A6.25710-- --===============0388144426== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0388144426==--