dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 107384] random tab crashes in firefox nightly
Date: Sat, 28 Jul 2018 23:16:35 +0000	[thread overview]
Message-ID: <bug-107384-502-WkPQWjcTeh@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-107384-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1494 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107384

--- Comment #7 from Christoph Haag <haagch@frickel.club> ---
(In reply to Chris Wilson from comment #5)
> Sigh.
> 
> diff --git a/src/loader/loader.c b/src/loader/loader.c
> index 43275484cc..87b7281f78 100644
> --- a/src/loader/loader.c
> +++ b/src/loader/loader.c
> @@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool
> *different_device)
>  static int
>  drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
>  {
> -   drmDevicePtr device;
> +   drmDevicePtr device = NULL;
>     int ret;
>  
>     if (drmGetDevice2(fd, 0, &device) == 0) {

Thanks, looks like this is my issue too.

diff --git a/src/loader/loader.c b/src/loader/loader.c
index 43275484cc2..02a1f97684f 100644
--- a/src/loader/loader.c
+++ b/src/loader/loader.c
@@ -167,7 +167,7 @@ static bool drm_device_matches_tag(drmDevicePtr device,
const char *prime_tag)

 static char *drm_get_id_path_tag_for_fd(int fd)
 {
-   drmDevicePtr device;
+   drmDevicePtr device = NULL;
    char *tag;

    if (drmGetDevice2(fd, 0, &device) != 0)
@@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool
*different_device)
 static int
 drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
 {
-   drmDevicePtr device;
+   drmDevicePtr device = NULL;
    int ret;

    if (drmGetDevice2(fd, 0, &device) == 0) {

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2431 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2018-07-28 23:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26  9:06 [Bug 107384] random tab crashes in firefox nightly bugzilla-daemon
2018-07-27  7:33 ` bugzilla-daemon
2018-07-28 12:47 ` bugzilla-daemon
2018-07-28 14:26 ` bugzilla-daemon
2018-07-28 17:22 ` bugzilla-daemon
2018-07-28 17:32 ` bugzilla-daemon
2018-07-28 18:52 ` bugzilla-daemon
2018-07-28 23:16 ` bugzilla-daemon [this message]
2018-07-30  8:40 ` bugzilla-daemon
2018-07-30 10:25 ` bugzilla-daemon
2018-08-07 13:41 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107384-502-WkPQWjcTeh@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox