[Bug 107482] Images gamma rendering issue

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1498 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

            Bug ID: 107482
           Summary: Images gamma rendering issue
           Product: DRI
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: esebaro@gmail.com

Created attachment 140962
  --> https://bugs.freedesktop.org/attachment.cgi?id=140962&action=edit
images gamma

I have a PC with:
MB: Asrock AM1B-ITX
CPU: AMD Kabini Athlon 5350 APU
iGPU: Radeon HD 8400 / R3 Series
Displays: DVI Asus, HDMI Samsung

kernel-4.15/4.16/4.17
xorg-server-1.19.5
xorg-drivers-1.19
xf86-video-amdgpu-18.0.1
xf86-video-ati-18.0.1
libdrm-2.4.92

When I increase the gamma to check the quality of images (xgamma -gamma 3),
some pixels are darker/colorful, it seems like gamma is not applied uniformly
for all pixels. This happens on all kernels with any video driver: radeon,
amdgpu, amdgpu-dc.

I thought there's something wrong with the images so I've edited them on Gimp
by  increasing brightness or change hue/saturation. This was fine until the
kernel 4.17 and the amdgpu-dc driver upgrade, images have again the issue. They
are fine with amdgpu.

Is there something I can do about this?
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2890 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 377 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

--- Comment #1 from Michel Dänzer <michel@daenzer.net> ---
Please attach the corresponding Xorg log file.

How did you capture the attached image? Can you also attach a corresponding
direct capture with a screenshot tool on that machine?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1119 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

--- Comment #2 from Sebastian Luncan <esebaro@gmail.com> ---
Created attachment 140974
  --> https://bugs.freedesktop.org/attachment.cgi?id=140974&action=edit
xorg log

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1156 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 695 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

--- Comment #3 from Sebastian Luncan <esebaro@gmail.com> ---
Created attachment 140975
  --> https://bugs.freedesktop.org/attachment.cgi?id=140975&action=edit
imagemagick original capture

These are the capture commands (ImageMagick) used with FVWM:

import -window $[w.id] -silent
"PNG24:$[infostore.mScreenshots]/screenshot-$(date +%F[%R]).png"
import -window root -silent "PNG24:$[infostore.mScreenshots]/screenshot-$(date
+%F[%R]).png"

Attached the original capture (without gamma).
For the first attached imaged I've applied gamma with Gimp.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1606 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 427 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #140974|text/x-log                  |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1073 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 996 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |NOTABUG

--- Comment #4 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Sebastian Luncan from comment #3)
> For the first attached imaged I've applied gamma with Gimp.

How exactly did you do that?

Anyway, I don't think there's a bug here. Gamma doesn't affect all colour
values the same way (in particular, 0 and the maximum value are preserved for
each colour component). The "colourful" pixels occur because the original
pixels have 0 or a very small value in some components but larger values in
others, which are affected differently by gamma.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2522 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

--- Comment #5 from Sebastian Luncan <esebaro@gmail.com> ---
Created attachment 141147
  --> https://bugs.freedesktop.org/attachment.cgi?id=141147&action=edit
Gamma amdgpu vs amdgpu-dc

I don't know how to capture the screen with gamma so I did a capture with
imagemagick and applied gamma with gimp so the issues are visible.

I've also took a picture (attached). On the left is amdgpu-dc on the right
amdgpu, gamma 3 (xgamma -gamma 3), kernel 4.17. See the trees and the grass on
the left. Why do they look different on the same gamma values?

As I said, this happened before and I've fixed the issue with gimp by changing
images brightness and hue/saturation, but now with amdgpu-dc from 4.17 the
issues are back.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1806 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sunpeng.li@amd.com

--- Comment #6 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Sebastian Luncan from comment #5)
> I've also took a picture (attached). On the left is amdgpu-dc on the right
> amdgpu, gamma 3 (xgamma -gamma 3), kernel 4.17. See the trees and the grass
> on the left. Why do they look different on the same gamma values?

Can you try if current upstream xf86-video-amdgpu Git master works better with
DC?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2237 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 469 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

--- Comment #7 from Sebastian Luncan <esebaro@gmail.com> ---
(In reply to Michel Dänzer from comment #6)
> Can you try if current upstream xf86-video-amdgpu Git master works better
> with DC?

It's the same.

I've also tried videos with gamma 3. All hardware decoded videos (h264) look
fine, software decoded have this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1342 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 232 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

--- Comment #8 from Michel Dänzer <michel@daenzer.net> ---
Leo, any ideas what's going on here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1030 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107482] Images gamma rendering issue

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 399 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107482

--- Comment #9 from Leo Li <sunpeng.li@amd.com> ---
Michel's right about xgamma leaving 0 and max per-channel values unmodified, so
the original issue is not-a-bug. Although I'm not sure why there's a difference
between amdgpu and dc, I'll have to look into it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel