[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cash

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1288 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

            Bug ID: 107552
           Summary: new handle table code makes dota2 vulkan crash at
                    start from an empty shader cash
           Product: DRI
           Version: DRI git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: sylvain.bertrand@gmail.com

linux amd-staging-drm-next 7b20167b9670150698201b1d9e4bddd75ad60491 (today)
libdrm 879d7c0298d1d4bc52d71d599cc07cafb4645808 (today)
llvm ac6c5d8a36474ca9216ee2628d6a267a72a44d32 (today)
mesa de57926dc909b3fb180ff06a6c5235309fdbf4df (today)
xserver 1fc20b985cc888345bc8c6fce7b43f10ce71fe43 (today)
xf86-video-amdgpu 08c4d42f43f80baa4bbc2ff9d0a422202cdc3538 (today)

amd gpu tahiti xt

Empty the shader cache in $HOME/.cache, start dota2 vulkan then it crashes in a
random location. Start it a second time, it works. Empty the shader cache, it
will crash again at first start.
I reverted libdrm to the pre-handle table version, then everything is fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2596 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 558 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

Sylvain BERTRAND <sylvain.bertrand@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|new handle table code makes |new handle table code makes
                   |dota2 vulkan crash at start |dota2 vulkan crash at start
                   |from an empty shader cash   |from an empty shader cache

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1269 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

--- Comment #1 from Christian König <ckoenig.leichtzumerken@gmail.com> ---
Well do you have a backtrace (with symbols)?

Otherwise it is really hard to guess what is going wrong here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 961 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

--- Comment #2 from Sylvain BERTRAND <sylvain.bertrand@gmail.com> ---
I did a lot of testing and dumped cores (libsegfault.so or catchsegv do not
work with steam/dota2), the issue is actually random: sometimes it works, most
of the time it crashes or hangs the vulkan dota2 process or hangs the whole
system. Using the steam overlay with vulkan dota2 makes the crashes/hangs do
happen way more often. The segfault backtraces happen in various parts of
vulkan dota2 (I got very few of them in mesa vulkan driver) and do not show
anything in libdrm*. I even did manage to crash the new steam chat (it was
unable to restart itself). If I read a video (gl accelerated) at the same time,
it changes the way vulkan dota2 crashes/hangs.

The system is stable again if I switch back to the previous libdrm hash table
code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1821 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 304 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

--- Comment #3 from Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> ---
Even if you cannot get a backtrace, can you bisect to show the exact commit
which causes the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1162 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 431 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

--- Comment #4 from Sylvain BERTRAND <sylvain.bertrand@gmail.com> ---
Sure, but there are very few commits. Basically, it's almost directly the
commits related to the handle table:
87fdbfb62fb3de6759d465d07cc13f922084694e stable commit
879d7c0298d1d4bc52d71d599cc07cafb4645808 unstable commit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1291 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 908 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

--- Comment #5 from Sylvain BERTRAND <sylvain.bertrand@gmail.com> ---
bisected:
--------------------------------------------------------------------------------
commit cbf0bb7f192b814be84dff538fb90dacf65958c7
Author: Christian König <christian.koenig@amd.com>
Date:   Thu Aug 2 10:45:19 2018 +0200

    amdgpu: always add all BOs to handle table

    This way we can always find a BO structure by its handle.

    Signed-off-by: Christian König <christian.koenig@amd.com>
    Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
    Reviewed-and-Tested-by: Junwei Zhang <Jerry.Zhang@amd.com>
--------------------------------------------------------------------------------
I am currently running libdrm from the commit right before this one, no pb so
far.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2001 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 381 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

--- Comment #6 from Christian König <ckoenig.leichtzumerken@gmail.com> ---
Created attachment 141104
  --> https://bugs.freedesktop.org/attachment.cgi?id=141104&action=edit
Possible fix

The attached patch should fix the issue, please test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1449 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 291 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

--- Comment #7 from Sylvain BERTRAND <sylvain.bertrand@gmail.com> ---
I applied on top of commit 1e12c16d7697a1223630a507c1032d940794039a

Stable so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1151 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 107552] new handle table code makes dota2 vulkan crash at start from an empty shader cache

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=107552

Christian König <ckoenig.leichtzumerken@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Christian König <ckoenig.leichtzumerken@gmail.com> ---
Thanks for the report, sounds like we can close this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2213 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel