From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 108514] heavy screen flickering with Mobility Radeon X1600 and kernel version 3.15rc2 onward Date: Thu, 14 Feb 2019 21:36:55 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1825245058==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 07F786E402 for ; Thu, 14 Feb 2019 21:36:55 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1825245058== Content-Type: multipart/alternative; boundary="15501802141.57D7d.30860" Content-Transfer-Encoding: 7bit --15501802141.57D7d.30860 Date: Thu, 14 Feb 2019 21:36:54 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D108514 --- Comment #30 from Paul Dufresne --- The following patch seems to work for me: client@client-LIFEBOOK-AH531 ~/T=C3=A9l=C3=A9chargements $ diff -u old/linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c --- old/linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c 2019-02-12 13:47:27.000000000 -0500 +++ linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c 2019-02-14 15:29:37.743229474 -0500 @@ -921,12 +921,14 @@ ref_div_max =3D max(min(100 / post_div, ref_div_max), 1u); /* get matching reference and feedback divider */ - *ref_div =3D min(max(DIV_ROUND_CLOSEST(den, post_div), 1u), ref_div= _max); + // was: *ref_div =3D min(max(DIV_ROUND_CLOSEST(den, post_div), 1u), ref_div_max); + *ref_div =3D min(max((den/post_div), 1u), ref_div_max); *fb_div =3D DIV_ROUND_CLOSEST(nom * *ref_div * post_div, den); /* limit fb divider to its maximum */ if (*fb_div > fb_div_max) { - *ref_div =3D DIV_ROUND_CLOSEST(*ref_div * fb_div_max, *fb_d= iv); + // was: *ref_div =3D DIV_ROUND_CLOSEST(*ref_div * fb_div_ma= x, *fb_div); + *ref_div =3D (*ref_div * fb_div_max) / (*fb_div); *fb_div =3D fb_div_max; } } client@client-LIFEBOOK-AH531 ~/T=C3=A9l=C3=A9chargements $ --=20 You are receiving this mail because: You are the assignee for the bug.= --15501802141.57D7d.30860 Date: Thu, 14 Feb 2019 21:36:54 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 30 on bug 10851= 4 from Paul Dufresne 
The following patch seems to work for me:
client@client-LIFEBOOK-AH531 ~/T=C3=A9l=C3=A9chargements $ diff -u
old/linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c
linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c
--- old/linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c   2019-02-12
13:47:27.000000000 -0500
+++ linux-4.19.21/drivers/gpu/drm/radeon/radeon_display.c       2019-02-14
15:29:37.743229474 -0500
@@ -921,12 +921,14 @@
        ref_div_max =3D max(min(100 / post_div, ref_div_max), 1u);

        /* get matching reference and feedback divider */
-       *ref_div =3D min(max(DIV_ROUND_CLOSEST(den, post_div), 1u), ref_div=
_max);
+       // was: *ref_div =3D min(max(DIV_ROUND_CLOSEST(den, post_div), 1u),
ref_div_max);
+       *ref_div =3D min(max((den/post_div), 1u), ref_div_max);
        *fb_div =3D DIV_ROUND_CLOSEST(nom * *ref_div * post_div, den);

        /* limit fb divider to its maximum */
        if (*fb_div > fb_div_max) {
-               *ref_div =3D DIV_ROUND_CLOSEST(*ref_div * fb_div_max, *fb_d=
iv);
+               // was: *ref_div =3D DIV_ROUND_CLOSEST(*ref_div * fb_div_ma=
x,
*fb_div);
+               *ref_div =3D (*ref_div * fb_div_max) / (*fb_div);
                *fb_div =3D fb_div_max;
        }
 }
client@client-LIFEBOOK-AH531 ~/T=C3=A9l=C3=A9chargements $

You are receiving this mail because:
  • You are the assignee for the bug.
= --15501802141.57D7d.30860-- --===============1825245058== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1825245058==--