[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 925 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

            Bug ID: 108889
           Summary: [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket -
                    incomplete - __igt_fork_helper: Assertion
                    `!proc->running' failed.
           Product: DRI
           Version: XOrg git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: IGT
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: martin.peres@free.fr

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5197/shard-iclb5/igt@sw_sync@sync_busy_fork_unixsocket.html

Starting subtest: sync_busy_fork_unixsocket
sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion `!proc->running'
failed.
Received signal SIGABRT.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2413 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 764 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

Martin Peres <martin.peres@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |ReadyForDev
           Priority|medium                      |high

--- Comment #1 from Martin Peres <martin.peres@free.fr> ---
Also seen on SKL:
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_149/fi-skl-6770hq/igt@sw_sync@sync_busy_fork.html

Starting subtest: sync_busy_fork
sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion `!proc->running'
failed.
Received signal SIGABRT.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2587 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 248 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

--- Comment #2 from Chris Wilson <chris@chris-wilson.co.uk> ---
So why was this marked incomplete and not CRASH?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 296 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

--- Comment #3 from Martin Peres <martin.peres@free.fr> ---
(In reply to Chris Wilson from comment #2)
> So why was this marked incomplete and not CRASH?

+1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1313 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 652 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

--- Comment #4 from CI Bug Log <cibuglog@gmail.com> ---
A CI Bug Log filter associated to this bug has been updated:

{- SKL ICL: igt@sw_sync@sync_busy_fork* - incomplete - __igt_fork_helper:
Assertion `!proc-&gt;running&#39; failed. -}
{+ HSW SKL ICL: igt@sw_sync@sync_busy_fork* - incomplete - __igt_fork_helper:
Assertion `!proc-&gt;running&#39; failed. +}

New failures caught by the filter:

*
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_186/fi-hsw-peppy/igt@sw_sync@sync_busy_fork_unixsocket.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1764 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 645 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

--- Comment #5 from CI Bug Log <cibuglog@gmail.com> ---
A CI Bug Log filter associated to this bug has been updated:

{- HSW SKL ICL: igt@sw_sync@sync_busy_fork* - incomplete - __igt_fork_helper:
Assertion `!proc-&gt;running&#39; failed. -}
{+ HSW SKL KBL ICL: igt@sw_sync@sync_busy_fork* - incomplete -
__igt_fork_helper: Assertion `!proc-&gt;running&#39; failed. +}

New failures caught by the filter:

*
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_191/fi-kbl-r/igt@sw_sync@sync_busy_fork.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1742 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 801 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

--- Comment #6 from CI Bug Log <cibuglog@gmail.com> ---
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* BLB BWR HSW BSW: Incomplete - igt_stop_helper: Assertion
`helper_was_alive(proc, status)&#39; failed
  -
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_195/fi-blb-e6850/igt@sw_sync@sync_busy_fork.html
  -
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_195/fi-bsw-n3050/igt@sw_sync@sync_busy_fork.html
  -
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_189/fi-hsw-peppy/igt@sw_sync@sync_busy_fork.html
  -
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_194/fi-bwr-2160/igt@sw_sync@sync_busy_fork.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2254 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 954 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

Chris Wilson <chris@chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Chris Wilson <chris@chris-wilson.co.uk> ---
commit 93c6b1ca84866fabe4601b1e93145209e4df1177
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Jan 30 22:16:39 2019 +0000

    sw_sync: Initialise struct before use

    sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion
`!proc->running'

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108889
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Jani Nikula <jani.nikula@intel.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3150 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1639 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

Martin Peres <martin.peres@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #8 from Martin Peres <martin.peres@free.fr> ---
(In reply to Chris Wilson from comment #7)
> commit 93c6b1ca84866fabe4601b1e93145209e4df1177
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Jan 30 22:16:39 2019 +0000
> 
>     sw_sync: Initialise struct before use
>     
>     sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion
> `!proc->running'
>     
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108889
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>     Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Thanks, but we still get the following :)

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_231/fi-bsw-n3050/igt@sw_sync@sync_busy_fork.html

Starting subtest: sync_busy_fork
sw_sync: ../lib/igt_core.c:1693: igt_stop_helper: Assertion
`helper_was_alive(proc, status)' failed.
Received signal SIGABRT.
Stack trace: 
 #0 [fatal_sig_handler+0xd5]
 #1 [killpg+0x40]
 #2 [gsignal+0xc7]
 #3 [abort+0x141]
 #4 [uselocale+0x33a]
 #5 [__assert_fail+0x42]
 #6 [igt_stop_helper+0xc3]
 #7 [test_sync_busy_fork+0x10e]
 #8 [__real_main860+0x1bc]
 #9 [main+0x44]
 #10 [__libc_start_main+0xe7]
 #11 [_start+0x2a]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 4001 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1179 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

Chris Wilson <chris@chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Chris Wilson <chris@chris-wilson.co.uk> ---
commit 520b6f7fbb6cb7dc99d689cc6c073fae1ccc8e7f
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Mar 15 23:00:33 2019 +0000

    sw_sync: Wait until the end

    If we allow a fork-helper to exit normally before the parent tries to
    reap the helper (fork-helpers are intended to be only used for
    persistent background loads), then the helper unhelpful aborts because
    the child exited cleanly.

    Simplify by not using the so called helpers at all.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108889
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Accidentally pushed, but worksforme so I hope no one notices.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3320 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

Lakshmi <lakshminarayana.vudum@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108889] [CI][SHARDS] igt@sw_sync@sync_busy_fork_unixsocket - incomplete - __igt_fork_helper: Assertion `!proc->running' failed.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108889

--- Comment #10 from CI Bug Log <cibuglog@gmail.com> ---
The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug
anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1330 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel