From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h Date: Fri, 14 Dec 2018 00:05:31 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1808916735==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 44A726E01D for ; Fri, 14 Dec 2018 00:05:31 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1808916735== Content-Type: multipart/alternative; boundary="15447459310.AdBFF5.18203" Content-Transfer-Encoding: 7bit --15447459310.AdBFF5.18203 Date: Fri, 14 Dec 2018 00:05:31 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109060 Bug ID: 109060 Summary: android-x86 64bit builds crashes due to android/gralloc_handle.h Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: other Status: NEW Severity: blocker Priority: medium Component: libdrm Assignee: dri-devel@lists.freedesktop.org Reporter: issor.oruam@gmail.com Created attachment 142809 --> https://bugs.freedesktop.org/attachment.cgi?id=3D142809&action=3Dedit draft patch that solves the crashes Hi, there is a series of Android apps using 32bit libs on 64bit Android that are crashing (Jackpal terminal, Sky Force, Olympus Rising, Vulkan V1, 3dmark benchmarks and many others) The cause is the difference in size of gralloc handle structs created by 32= bit libraries and 64bit architetures libraries. The problem was observed and patched in gbm_gralloc in the past by Chih-Wei Huang, but it was not taken into account in later evolution, now with android/gralloc_handle.h in libdrm the problem is again present, because the handle sizes in 32bit and 64bit are again different. The attached draft patch solves the issue, tested on all apps that were crashing Please review and provide feedback Mauro --=20 You are receiving this mail because: You are the assignee for the bug.= --15447459310.AdBFF5.18203 Date: Fri, 14 Dec 2018 00:05:31 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 109060
Summary android-x86 64bit builds crashes due to android/gralloc_handl= e.h
Product DRI
Version DRI git
Hardware x86-64 (AMD64)
OS other
Status NEW
Severity blocker
Priority medium
Component libdrm
Assignee dri-devel@lists.freedesktop.org
Reporter issor.oruam@gmail.com 

Created atta=
chment 142809 [details] [=
review]
draft patch that solves the crashes

Hi,
there is a series of Android apps using 32bit libs on 64bit Android that are
crashing (Jackpal terminal, Sky Force, Olympus Rising, Vulkan V1, 3dmark
benchmarks and many others)

The cause is the difference in size of gralloc handle structs created by 32=
bit
libraries and 64bit architetures libraries.

The problem was observed and patched in gbm_gralloc in the past by Chih-Wei
Huang, but it was not taken into account in later evolution,
now with android/gralloc_handle.h in libdrm the problem is again present,
because the handle sizes in 32bit and 64bit are again different.

The attached draft patch solves the issue, tested on all apps that were
crashing
Please review and provide feedback

Mauro

You are receiving this mail because:
  • You are the assignee for the bug.
= --15447459310.AdBFF5.18203-- --===============1808916735== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1808916735==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h Date: Tue, 18 Dec 2018 21:25:09 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48FAD6ED14 for ; Tue, 18 Dec 2018 20:25:13 +0000 (UTC) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGV5IENoaWgtV2VpICYgTWF1cm8sCgpUaGlzIGZpeCBsb29rcyBnb29kIHRvIG1lLgpDbGVhbmVk IHVwIHBhdGNoIG5hbWUgYW5kIHB1c2hlZCB0byByZXBvLgoKClJvYi4KCk9uIDIwMTgtMTItMTQg MDE6MDUsIGJ1Z3ppbGxhLWRhZW1vbkBmcmVlZGVza3RvcC5vcmcgd3JvdGU6Cj4gQnVnIElEIAkx MDkwNjAgPGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwOTA2 MD4KPiBTdW1tYXJ5IAlhbmRyb2lkLXg4NiA2NGJpdCBidWlsZHMgY3Jhc2hlcyBkdWUgdG8gYW5k cm9pZC9ncmFsbG9jX2hhbmRsZS5oCj4gUHJvZHVjdCAJRFJJCj4gVmVyc2lvbiAJRFJJIGdpdAo+ IEhhcmR3YXJlIAl4ODYtNjQgKEFNRDY0KQo+IE9TIAlvdGhlcgo+IFN0YXR1cyAJTkVXCj4gU2V2 ZXJpdHkgCWJsb2NrZXIKPiBQcmlvcml0eSAJbWVkaXVtCj4gQ29tcG9uZW50IAlsaWJkcm0KPiBB c3NpZ25lZSAJZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFJlcG9ydGVyIAlpc3Nv ci5vcnVhbUBnbWFpbC5jb20KPiAKPiBDcmVhdGVkYXR0YWNobWVudCAxNDI4MDkgPGF0dGFjaG1l bnQuY2dpP2lkPTE0MjgwOT4gW2RldGFpbHNdIAo+IDxhdHRhY2htZW50LmNnaT9pZD0xNDI4MDkm YWN0aW9uPWVkaXQ+ICBbcmV2aWV3XSAgPHBhZ2UuY2dpP2lkPXNwbGludGVyLmh0bWwmYnVnPTEw OTA2MCZhdHRhY2htZW50PTE0MjgwOT4KPiBkcmFmdCBwYXRjaCB0aGF0IHNvbHZlcyB0aGUgY3Jh c2hlcwo+IAo+IEhpLAo+IHRoZXJlIGlzIGEgc2VyaWVzIG9mIEFuZHJvaWQgYXBwcyB1c2luZyAz MmJpdCBsaWJzIG9uIDY0Yml0IEFuZHJvaWQgdGhhdCBhcmUKPiBjcmFzaGluZyAoSmFja3BhbCB0 ZXJtaW5hbCwgU2t5IEZvcmNlLCBPbHltcHVzIFJpc2luZywgVnVsa2FuIFYxLCAzZG1hcmsKPiBi ZW5jaG1hcmtzIGFuZCBtYW55IG90aGVycykKPiAKPiBUaGUgY2F1c2UgaXMgdGhlIGRpZmZlcmVu Y2UgaW4gc2l6ZSBvZiBncmFsbG9jIGhhbmRsZSBzdHJ1Y3RzIGNyZWF0ZWQgYnkgMzJiaXQKPiBs aWJyYXJpZXMgYW5kIDY0Yml0IGFyY2hpdGV0dXJlcyBsaWJyYXJpZXMuCj4gCj4gVGhlIHByb2Js ZW0gd2FzIG9ic2VydmVkIGFuZCBwYXRjaGVkIGluIGdibV9ncmFsbG9jIGluIHRoZSBwYXN0IGJ5 IENoaWgtV2VpCj4gSHVhbmcsIGJ1dCBpdCB3YXMgbm90IHRha2VuIGludG8gYWNjb3VudCBpbiBs YXRlciBldm9sdXRpb24sCj4gbm93IHdpdGggYW5kcm9pZC9ncmFsbG9jX2hhbmRsZS5oIGluIGxp YmRybSB0aGUgcHJvYmxlbSBpcyBhZ2FpbiBwcmVzZW50LAo+IGJlY2F1c2UgdGhlIGhhbmRsZSBz aXplcyBpbiAzMmJpdCBhbmQgNjRiaXQgYXJlIGFnYWluIGRpZmZlcmVudC4KPiAKPiBUaGUgYXR0 YWNoZWQgZHJhZnQgcGF0Y2ggc29sdmVzIHRoZSBpc3N1ZSwgdGVzdGVkIG9uIGFsbCBhcHBzIHRo YXQgd2VyZQo+IGNyYXNoaW5nCj4gUGxlYXNlIHJldmlldyBhbmQgcHJvdmlkZSBmZWVkYmFjawo+ IAo+IE1hdXJvCj4gCj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiBZb3UgYXJlIHJlY2Vpdmlu ZyB0aGlzIG1haWwgYmVjYXVzZToKPiAKPiAgICogWW91IGFyZSB0aGUgYXNzaWduZWUgZm9yIHRo ZSBidWcuCj4gCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h Date: Wed, 17 Apr 2019 17:16:01 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0755045922==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id E379C6E081 for ; Wed, 17 Apr 2019 17:16:01 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0755045922== Content-Type: multipart/alternative; boundary="15555213612.8bd41fa.20051" Content-Transfer-Encoding: 7bit --15555213612.8bd41fa.20051 Date: Wed, 17 Apr 2019 17:16:01 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109060 Emil Velikov changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Emil Velikov --- Seems like Rob pushed the patch, but forgot to update the bugreport - oops = ;-) Thanks for the fix gents. commit 597725e9511f8c0405fdd8d92d749bce58c0bce3 Author: Mauro Rossi Date: Tue Dec 11 23:22:35 2018 +0100 android: Fix 32-bit app crashing in 64-bit Android --=20 You are receiving this mail because: You are the assignee for the bug.= --15555213612.8bd41fa.20051 Date: Wed, 17 Apr 2019 17:16:01 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Emil Velikov changed bug 10906= 0
What Removed Added
Resolution --- FIXED
Status NEW RESOLVED

Commen= t # 1 on bug 10906= 0 from Emil Velikov 
Seems like Rob pushed the patch, but forgot to update the bugr=
eport - oops ;-)
Thanks for the fix gents.

commit 597725e9511f8c0405fdd8d92d749bce58c0bce3
Author: Mauro Rossi <issor.=
oruam@gmail.com>
Date:   Tue Dec 11 23:22:35 2018 +0100

    android: Fix 32-bit app crashing in 64-bit Android

You are receiving this mail because:
  • You are the assignee for the bug.
= --15555213612.8bd41fa.20051-- --===============0755045922== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0755045922==--