From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109135] R9 390 hangs at boot with DPM/DC enabled for kernels 4.19.x and above, says KMS not supported Date: Wed, 16 Jan 2019 18:58:15 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0861052315==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 503FE6F1E1 for ; Wed, 16 Jan 2019 18:58:15 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0861052315== Content-Type: multipart/alternative; boundary="15476650952.75C2.12547" Content-Transfer-Encoding: 7bit --15476650952.75C2.12547 Date: Wed, 16 Jan 2019 18:58:15 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109135 --- Comment #23 from Alex Deucher --- (In reply to iive from comment #22) >=20 > It is code refactoring. It doesn't remove, add or modify any functionalit= y. > It just changes how some functions are called. (1 function pointer and > switch/case, instead of 3 function pointers.) > I honestly could not spot what might be wrong with it. this changed: @@ -1751,10 +1751,10 @@ void amdgpu_dpm_enable_uvd(struct amdgpu_device *ad= ev, bool enable) void amdgpu_dpm_enable_vce(struct amdgpu_device *adev, bool enable) { - if (adev->powerplay.pp_funcs->powergate_vce) { + if (adev->powerplay.pp_funcs->set_powergating_by_smu) { CI asic never had a powergate_vce callback before, so that code was never called for vce previously, at least for the old dpm implementation. For the new on, it actually had a callback for vce powergating, but perhaps there w= as a bug in that code around the time this code was changed. --=20 You are receiving this mail because: You are the assignee for the bug.= --15476650952.75C2.12547 Date: Wed, 16 Jan 2019 18:58:15 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 23 on bug 10913= 5 from Alex Deucher 
(In reply to iive from comment #22)
>=20
> It is code refactoring. It doesn't remove, add or modify any functiona=
lity.
> It just changes how some functions are called. (1 function pointer and
> switch/case, instead of 3 function pointers.)
> I honestly could not spot what might be wrong with it.

this changed:
@@ -1751,10 +1751,10 @@ void amdgpu_dpm_enable_uvd(struct a=
mdgpu_device *adev,
bool enable)

 void amdgpu_dpm_enable_vce(struct amdgpu_device *adev, bool enable)
 {
-       if (adev->powerplay.pp_funcs->powergate_vce) {
+       if (adev->powerplay.pp_funcs->set_powergating_by_smu) {

CI asic never had a powergate_vce callback before, so that code was never
called for vce previously, at least for the old dpm implementation.  For the
new on, it actually had a callback for vce powergating, but perhaps there w=
as a
bug in that code around the time this code was changed.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15476650952.75C2.12547-- --===============0861052315== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0861052315==--