From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109265] [regression, bisected] arb_texture_multisample texelfetch piglit test failing on NIR backend Date: Mon, 14 Jan 2019 06:19:27 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0526018076==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 34913897F5 for ; Mon, 14 Jan 2019 06:19:27 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0526018076== Content-Type: multipart/alternative; boundary="15474467671.5CaA4CD.25050" Content-Transfer-Encoding: 7bit --15474467671.5CaA4CD.25050 Date: Mon, 14 Jan 2019 06:19:27 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109265 --- Comment #4 from Timothy Arceri --- This is odd. As far as I can tell the shader variant produced after loading from the case is the same as the one produced when the cache is disabled. Its also a fairly simple program. From tests/texturing/shaders/texelFetch.c= the offending program is: int vs =3D piglit_compile_shader_text(GL_VERTEX_SHADER, "#version 130\n" "#extension GL_ARB_explicit_attrib_location: require\n" "layout(location=3D0) in vec4 pos;\n" "void main() {\n" " gl_Position =3D pos;\n" "}\n"); (void)!asprintf(&fs_code, "#version 130\n" "#extension GL_ARB_explicit_attrib_location: require\n" "#extension GL_ARB_fragment_coord_conventions: require\n" "uniform int layer;\n" "uniform int si;\n" "layout(pixel_center_integer) in vec4 gl_FragCoord;\n" "layout(location=3D0) out %s o;\n" "void main() {\n" " o =3D %s(%sgl_FragCoord.x, gl_FragCoord.y, layer, si);\n" "}\n", sampler.return_type, sampler.return_type, sampler.data_type =3D=3D GL_UNSIGNED_INT ? "" : "-"); We must not be setting a flag somewhere, but I've looked over the code that handles the cache multiple time now and can't spot any real difference bet= ween tgsi and nir. --=20 You are receiving this mail because: You are the assignee for the bug.= --15474467671.5CaA4CD.25050 Date: Mon, 14 Jan 2019 06:19:27 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 4 on bug 10926= 5 from Timothy Arceri
This is odd. As far as I can tell the shader variant produced =
after loading
from the case is the same as the one produced when the cache is disabled.

Its also a fairly simple program. From tests/texturing/shaders/texelFetch.c=
 the
offending program is:

    int vs =3D piglit_compile_shader_text(GL_VERTEX_SHADER,
            "#version 130\n"
            "#extension GL_ARB_explicit_attrib_location: require\n&quo=
t;
            "layout(location=3D0) in vec4 pos;\n"
            "void main() {\n"
            "   gl_Position =3D pos;\n"
            "}\n");
    (void)!asprintf(&fs_code,
            "#version 130\n"
            "#extension GL_ARB_explicit_attrib_location: require\n&quo=
t;
            "#extension GL_ARB_fragment_coord_conventions: require\n&q=
uot;
            "uniform int layer;\n"
            "uniform int si;\n"
            "layout(pixel_center_integer) in vec4 gl_FragCoord;\n"
            "layout(location=3D0) out %s o;\n"
            "void main() {\n"
            "  o =3D %s(%sgl_FragCoord.x, gl_FragCoord.y, layer, si);\=
n"
            "}\n",
            sampler.return_type,
            sampler.return_type,
            sampler.data_type =3D=3D GL_UNSIGNED_INT ? "" : "=
;-");

We must not be setting a flag somewhere, but I've looked over the code that
handles the cache multiple  time now and can't spot any real difference bet=
ween
tgsi and nir.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15474467671.5CaA4CD.25050-- --===============0526018076== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0526018076==--