From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109345] drm-next-2018-12-14 -Linux PPC Date: Thu, 09 May 2019 11:52:24 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1984433089==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 5273F89B98 for ; Thu, 9 May 2019 11:52:24 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1984433089== Content-Type: multipart/alternative; boundary="15574027442.8ce91B.1464" Content-Transfer-Encoding: 7bit --15574027442.8ce91B.1464 Date: Thu, 9 May 2019 11:52:24 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109345 --- Comment #39 from Christian Zigotzky --- Hi All, Allan has successfully tested the eleventh test kernel. He wrote: Christian DRM11 boots to Firepro. ace ------ We have a result! git bisect good The following commit is responsible for the issue: 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa is the first bad commit commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa Author: Aaron Ma Date: Sat Sep 1 02:20:00 2018 +0800 vgaarb: Keep adding VGA device in queue If failed to find the deivice owning the boot framebuffer, try to use the first VGA device instead of the last one. Usually the 1st device is integrated GPU who owns the boot framebuffer. Signed-off-by: Aaron Ma Acked-by: Alex Deucher Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/1535739600-8842-2-git-send-em= ail-aaron.ma@canonical.com :040000 040000 2d69570b87946ba42095609c945f04de9ad24ef7 3d86752f71500726f20d7d503128119f9b249175 M drivers ------ I undid these changes in the file 'drivers/gpu/vga/vgaarb.c' and created another test kernel today. Download: http://www.xenosoft.de/linux-image-5.2-alpha2-X1000_X5000.tar.gz You can undo the commit with the following patch: diff -rupN a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c --- a/drivers/gpu/vga/vgaarb.c 2019-05-09 07:56:27.595746473 +0200 +++ b/drivers/gpu/vga/vgaarb.c 2019-05-09 08:00:06.352660688 +0200 @@ -725,7 +725,7 @@ static bool vga_arbiter_add_pci_device(s vga_arbiter_check_bridge_sharing(vgadev); /* Add to the list */ - list_add_tail(&vgadev->list, &vga_list); + list_add(&vgadev->list, &vga_list); vga_count++; vgaarb_info(&pdev->dev, "VGA device added: decodes=3D%s,owns=3D%s,lock= s=3D%s\n", vga_iostate_to_str(vgadev->decodes), ------ @Allan (acefnq/ace) Please test it. Thanks, Christian --=20 You are receiving this mail because: You are the assignee for the bug.= --15574027442.8ce91B.1464 Date: Thu, 9 May 2019 11:52:24 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 39 on bug 10934= 5 from Christian Zigotzky
Hi All,

Allan has successfully tested the eleventh test kernel.

He wrote:

Christian
DRM11 boots to Firepro.

ace

------

We have a result!

git bisect good

The following commit is responsible for the issue:

3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa is the first bad commit
commit 3d42f1ddc47a69c0ce155f9f30d764c4d689a5fa
Author: Aaron Ma <aaron.ma=
@canonical.com>
Date:   Sat Sep 1 02:20:00 2018 +0800

    vgaarb: Keep adding VGA device in queue

    If failed to find the deivice owning the boot framebuffer,
    try to use the first VGA device instead of the last one.

    Usually the 1st device is integrated GPU who owns the boot framebuffer.

    Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link:
https://patchwork.freedesktop.or=
g/patch/msgid/1535739600-8842-2-git-send-email-aaron.ma@canonical.com

:040000 040000 2d69570b87946ba42095609c945f04de9ad24ef7
3d86752f71500726f20d7d503128119f9b249175 M   drivers

------

I undid these changes in the file 'drivers/gpu/vga/vgaarb.c' and created
another test kernel today.

Download: http://www.xenosoft.de/linux-image-5.2-alpha2-X1000_X5000.tar.g=
z

You can undo the commit with the following patch:

diff -rupN a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c
--- a/drivers/gpu/vga/vgaarb.c    2019-05-09 07:56:27.595746473 +0200
+++ b/drivers/gpu/vga/vgaarb.c    2019-05-09 08:00:06.352660688 +0200
@@ -725,7 +725,7 @@ static bool vga_arbiter_add_pci_device(s
     vga_arbiter_check_bridge_sharing(vgadev);

     /* Add to the list */
-    list_add_tail(&vgadev->list, &vga_list);
+    list_add(&vgadev->list, &vga_list);
     vga_count++;
     vgaarb_info(&pdev->dev, "VGA device added: decodes=3D%s,ow=
ns=3D%s,locks=3D%s\n",
         vga_iostate_to_str(vgadev->decodes),

------

@Allan (acefnq/ace)
Please test it.

Thanks,
Christian


You are receiving this mail because:
  • You are the assignee for the bug.
= --15574027442.8ce91B.1464-- --===============1984433089== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1984433089==--