From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@freedesktop.org
Subject: [Bug 109587] "xf86drm: Add drmIsMaster()" commit breaks X server
builds
Date: Mon, 11 Feb 2019 16:42:41 +0000
Message-ID:
References:
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1837563043=="
Return-path:
Received: from culpepper.freedesktop.org (culpepper.freedesktop.org
[IPv6:2610:10:20:722:a800:ff:fe98:4b55])
by gabe.freedesktop.org (Postfix) with ESMTP id 547DB6E285
for ; Mon, 11 Feb 2019 16:42:41 +0000 (UTC)
In-Reply-To:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
To: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org
--===============1837563043==
Content-Type: multipart/alternative; boundary="15499033612.EF9CdC9.26579"
Content-Transfer-Encoding: 7bit
--15499033612.EF9CdC9.26579
Date: Mon, 11 Feb 2019 16:42:41 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
https://bugs.freedesktop.org/show_bug.cgi?id=3D109587
Eero Tamminen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Eero Tamminen ---
Fixed by:
-----------------------------------------------------
commit eba6609b7bee5a56fa5334992b1e6f3aef8d244a
Author: Eric Engestrom
Date: Fri Feb 8 14:46:07 2019 +0000
xf86drm: fix return type for drmIsMaster()
Xserver has struct members named `bool`, which means the last commit
breaks its build with errors like this:
error: two or more data types in declaration specifiers
Bool bool;
^
Fix this by making it return a 0/1 integer, with the same semantic as
the boolean it was before.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=3D109587
Fixes: 17dfe3ac93217b43f93b "xf86drm: Add drmIsMaster()"
Cc: Christopher James Halse Rogers
Signed-off-by: Eric Engestrom
Reviewed-by: Emil Velikov
-----------------------------------------------------
I hope somebody fixes also those X server xf86Opt.h & winconfig.h headers s=
oon
as even some of X server code itself is using stdbool.h:
-----------------------------------------------------
$ git grep stdbool.h
hw/xquartz/GL/capabilities.h:#include
hw/xquartz/mach-startup/bundle-main.c:#include
hw/xwin/winmultiwindowicons.c:#include
test/damage/primitives.c:#include
test/simple-xinit.c:#include
-----------------------------------------------------
--=20
You are receiving this mail because:
You are the assignee for the bug.=
--15499033612.EF9CdC9.26579
Date: Mon, 11 Feb 2019 16:42:41 +0000
MIME-Version: 1.0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://bugs.freedesktop.org/
Auto-Submitted: auto-generated
Eero Tamminen
changed
bug 10958=
7
| What |
Removed |
Added |
| Status |
NEW
|
RESOLVED
|
| Resolution |
---
|
FIXED
|
Commen=
t # 1
on bug 10958=
7
from Eero Tamminen
Fixed by:
-----------------------------------------------------
commit eba6609b7bee5a56fa5334992b1e6f3aef8d244a
Author: Eric Engestrom <=
eric.engestrom@intel.com>
Date: Fri Feb 8 14:46:07 2019 +0000
xf86drm: fix return type for drmIsMaster()
Xserver has struct members named `bool`, which means the last commit
breaks its build with errors like this:
error: two or more data types in declaration specifiers
Bool bool;
^
Fix this by making it return a 0/1 integer, with the same semantic as
the boolean it was before.
Bug: https://bugs.freedesktop.org/show_bug.=
cgi?id=3D109587
Fixes: 17dfe3ac93217b43f93b "xf86drm: Add drmIsMaster()"
Cc: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
-----------------------------------------------------
I hope somebody fixes also those X server xf86Opt.h & winconfig.h heade=
rs soon
as even some of X server code itself is using stdbool.h:
-----------------------------------------------------
$ git grep stdbool.h
hw/xquartz/GL/capabilities.h:#include <stdbool.h>
hw/xquartz/mach-startup/bundle-main.c:#include <stdbool.h>
hw/xwin/winmultiwindowicons.c:#include <stdbool.h>
test/damage/primitives.c:#include <stdbool.h>
test/simple-xinit.c:#include <stdbool.h>
-----------------------------------------------------
You are receiving this mail because:
- You are the assignee for the bug.
=
--15499033612.EF9CdC9.26579--
--===============1837563043==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==
--===============1837563043==--