dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 110140] Green bottom half of video frame when using JPEG acceleration (vcn_v1_0_jpeg_ring_emit_fence() WARNING)
Date: Sun, 17 Mar 2019 22:16:30 +0000	[thread overview]
Message-ID: <bug-110140-502-ARB1nSfzc1@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-110140-502@http.bugs.freedesktop.org/>


[-- Attachment #1.1: Type: text/plain, Size: 1989 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110140

--- Comment #7 from Rafał Miłecki <zajec5@gmail.com> ---
Thanks for looking at this Leo!

Initially I didn't realize the consequences of your patch. I hopefully
understand it now.

Before the commit 36258308a794 ("st/va: fix the incorrect max profiles report")
my Chromium was simply NOT USING any Video Acceleration. Chromium was
complaining with the following errors:
[21202:21202:0317/122002.223002:ERROR:vaapi_wrapper.cc(587)] :
vaQueryConfigProfiles returned: 14
[21202:21202:0317/122002.223045:ERROR:vaapi_wrapper.cc(587)] :
vaQueryConfigProfiles returned: 14

So your change didn't introduce any regression in JPEG hardware decoding. It
only exposed an existing bug by allowing Chromium to use Video Acceleration.

*****

Let me provide some new (hopefully useful) info on this problem:

1) This problem is clearly about the JPEG decoding. If I revert commit
55e7de7b1935 ("radeonsi: enable vcn jpeg decode for raven") from any recent
branch (18.3, 19.0 or master) the problem disappears.

2) The problem exists from the beginning. If I do:
git checkout 55e7de7b1935
git cherry-pick 36258308a794
git cherry-pick dafa02c980c1
I get a Chromium with working Video Acceleration AND half bottom of webcam
frames being green.

3) I tested few branches:
18.3: bottom half of webcam frames are green
19.0: whole webcam frames are green
master: whole webcam frames are green

As you can see things got worse with the 19.0 branch (frames are totally green
instead of half green). That regression was added by the commit 1b25d340b791
("radeonsi: use compute for resource_copy_region when possible"). Hopefully
this is some hint on what's wrong and what's causing the original problem.

*****

Leo: I didn't try any other players, I've yet to learn how to use JPEG hw
decoding with some other application/player.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2910 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-03-17 22:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-16 17:42 [Bug 110140] Green bottom half of video frame when using JPEG acceleration (vcn_v1_0_jpeg_ring_emit_fence() WARNING) bugzilla-daemon
2019-03-16 17:48 ` bugzilla-daemon
2019-03-16 17:48 ` bugzilla-daemon
2019-03-16 23:20 ` bugzilla-daemon
2019-03-16 23:51 ` bugzilla-daemon
2019-03-17  2:24 ` bugzilla-daemon
2019-03-17  2:42 ` bugzilla-daemon
2019-03-17 22:16 ` bugzilla-daemon [this message]
2019-03-17 22:19 ` bugzilla-daemon
2019-03-18 13:12 ` bugzilla-daemon
2019-09-25 18:49 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-110140-502-ARB1nSfzc1@http.bugs.freedesktop.org/ \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox