From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110257] Major artifacts in mpeg2 vaapi hw decoding Date: Wed, 27 Mar 2019 11:23:33 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1654390077==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A5A16E0E7 for ; Wed, 27 Mar 2019 11:23:33 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1654390077== Content-Type: multipart/alternative; boundary="15536858131.C51bCdA0.22028" Content-Transfer-Encoding: 7bit --15536858131.C51bCdA0.22028 Date: Wed, 27 Mar 2019 11:23:33 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110257 Bug ID: 110257 Summary: Major artifacts in mpeg2 vaapi hw decoding Product: Mesa Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: 67b0226d@casix.org QA Contact: dri-devel@lists.freedesktop.org Created attachment 143787 --> https://bugs.freedesktop.org/attachment.cgi?id=3D143787&action=3Dedit hardware-decoded screenshot Hi, on latest Mesa I still get tons of artifacts when decoding MPEG2 on my AMD = card via VAAPI, to the point where it is not usable for video decoding at all to= be honest. I've attached sample screenshots to show the problem - one software-decoded= and one hardware-decoded via libva in mpv. The sample video is taken from https://www.w6rz.net/1080p25.zip but the artifacts are visible more or less on any MPEG2 video including DVDs. There is this older bug report: https://bugs.freedesktop.org/show_bug.cgi?id=3D93760 but I'm not sure it's related because I do not get any assertion failure and it vaguely reads lik= e it has been fixed? For clarification, I see no artifacts with VDPAU. Tested with Mesa-19.1.0-devel (git-bea540173c), libva 2.5.0-pre1 (git-c98b06d2b8), FFmpeg N-93467-g54655623a8 VAAPI driver string: Mesa Gallium driver 19.1.0-devel for Radeon RX 580 Ser= ies (POLARIS10, DRM 3.27.0, 4.20.13-arch1-1-ARCH, LLVM 7.0.1) I verified this with mpv, gstreamer and Kodi. mpv seems to have disabled mpeg2 hw decoding by default due to this problem: https://github.com/mpv-player/mpv/commit/3dd59dbe In Kodi we cannot go this route because we want to support low-end hardware that might have trouble decoding 1080p in software out-of-the-box. I want to avoid having to blacklist the radeon vaapi driver for mpeg2 if possible. --=20 You are receiving this mail because: You are the assignee for the bug.= --15536858131.C51bCdA0.22028 Date: Wed, 27 Mar 2019 11:23:33 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 110257
Summary Major artifacts in mpeg2 vaapi hw decoding
Product Mesa
Version unspecified
Hardware All
OS All
Status NEW
Severity major
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter 67b0226d@casix.org
QA Contact dri-devel@lists.freedesktop.org

Created attachment 1=
43787 [details]
hardware-decoded screenshot

Hi,

on latest Mesa I still get tons of artifacts when decoding MPEG2 on my AMD =
card
via VAAPI, to the point where it is not usable for video decoding at all to=
 be
honest.
I've attached sample screenshots to show the problem - one software-decoded=
 and
one hardware-decoded via libva in mpv.
The sample video is taken from https://www.w6rz.net/1080p25.zip but the
artifacts are visible more or less on any MPEG2 video including DVDs.

There is this older bug report:
https://bugs.freedesktop.org/show_bug.c=
gi?id=3D93760 but I'm not sure it's
related because I do not get any assertion failure and it vaguely reads lik=
e it
has been fixed?

For clarification, I see no artifacts with VDPAU.

Tested with Mesa-19.1.0-devel (git-bea540173c), libva 2.5.0-pre1
(git-c98b06d2b8), FFmpeg N-93467-g54655623a8
VAAPI driver string: Mesa Gallium driver 19.1.0-devel for Radeon RX 580 Ser=
ies
(POLARIS10, DRM 3.27.0, 4.20.13-arch1-1-ARCH, LLVM 7.0.1)

I verified this with mpv, gstreamer and Kodi.
mpv seems to have disabled mpeg2 hw decoding by default due to this problem:
https://githu=
b.com/mpv-player/mpv/commit/3dd59dbe
In Kodi we cannot go this route because we want to support low-end hardware
that might have trouble decoding 1080p in software out-of-the-box.
I want to avoid having to blacklist the radeon vaapi driver for mpeg2 if
possible.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15536858131.C51bCdA0.22028-- --===============1654390077== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1654390077==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110257] Major artifacts in mpeg2 vaapi hw decoding Date: Wed, 27 Mar 2019 11:23:51 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1034924380==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 369276E0F5 for ; Wed, 27 Mar 2019 11:23:51 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1034924380== Content-Type: multipart/alternative; boundary="15536858310.Eca0b62f.21970" Content-Transfer-Encoding: 7bit --15536858310.Eca0b62f.21970 Date: Wed, 27 Mar 2019 11:23:51 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110257 --- Comment #1 from 67b0226d@casix.org --- Created attachment 143788 --> https://bugs.freedesktop.org/attachment.cgi?id=3D143788&action=3Dedit software-decoded screenshot --=20 You are receiving this mail because: You are the assignee for the bug.= --15536858310.Eca0b62f.21970 Date: Wed, 27 Mar 2019 11:23:51 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 1 on bug 11025= 7 from 67b0226d@casix= .org
Created attachment 1=
43788 [details]
software-decoded screenshot


You are receiving this mail because:
  • You are the assignee for the bug.
= --15536858310.Eca0b62f.21970-- --===============1034924380== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1034924380==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110257] Major artifacts in mpeg2 vaapi hw decoding Date: Wed, 27 Mar 2019 11:27:42 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0827949583==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 397A46E0F4 for ; Wed, 27 Mar 2019 11:27:42 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0827949583== Content-Type: multipart/alternative; boundary="15536860620.8c9CAF.23515" Content-Transfer-Encoding: 7bit --15536860620.8c9CAF.23515 Date: Wed, 27 Mar 2019 11:27:42 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110257 67b0226d@casix.org changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |git --=20 You are receiving this mail because: You are the assignee for the bug.= --15536860620.8c9CAF.23515 Date: Wed, 27 Mar 2019 11:27:42 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated 67b0226d@casix.org changed bug 11025= 7
What Removed Added
Version unspecified git


You are receiving this mail because:
  • You are the assignee for the bug.
= --15536860620.8c9CAF.23515-- --===============0827949583== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0827949583==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110257] Major artifacts in mpeg2 vaapi hw decoding Date: Fri, 17 May 2019 04:52:19 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0139936752==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id E40C289823 for ; Fri, 17 May 2019 04:52:19 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0139936752== Content-Type: multipart/alternative; boundary="15580687393.9a8de1.2332" Content-Transfer-Encoding: 7bit --15580687393.9a8de1.2332 Date: Fri, 17 May 2019 04:52:19 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110257 --- Comment #2 from Andrew Randrianasulu --- wasn't this fixed by https://cgit.freedesktop.org/mesa/mesa/commit/?id=3Dd507bcdcf26b417dea20109= 0165af651253b6b11=20 ---------- st/va: reverse qt matrix back to its original order The quantiser matrix that VAAPI provides has been applied with inverse z-sc= an. However, what we expect in MPEG2 picture description is the original order. Therefore, we need to reverse it back to its original order. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D110257 Cc: mesa-stable@lists.freedesktop.org ---------- I can only test with Cinelerra-GG, and my nv92 crad decodes 1080p25 mpeg2 v= ery slowly (video decoder clock problem) - but for me images were ok! --=20 You are receiving this mail because: You are the assignee for the bug.= --15580687393.9a8de1.2332 Date: Fri, 17 May 2019 04:52:19 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 2 on bug 11025= 7 from Andrew Randrianasulu
wasn't this fixed by
https://cgit.freedesktop.org/mesa/mesa/commit=
/?id=3Dd507bcdcf26b417dea201090165af651253b6b11=20

----------
st/va: reverse qt matrix back to its original order
The quantiser matrix that VAAPI provides has been applied with inverse z-sc=
an.
However, what we expect in MPEG2 picture description is the original order.
Therefore, we need to reverse it back to its original order.

Bugzilla: https://bugs.freedesktop.org/show_bug.=
cgi?id=3D110257
Cc: mesa-stable=
4;lists.freedesktop.org
----------

I can only test with Cinelerra-GG, and my nv92 crad decodes 1080p25 mpeg2 v=
ery
slowly (video decoder clock problem) - but for me images were ok!


You are receiving this mail because:
  • You are the assignee for the bug.
= --15580687393.9a8de1.2332-- --===============0139936752== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0139936752==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110257] Major artifacts in mpeg2 vaapi hw decoding Date: Fri, 17 May 2019 05:49:40 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0984854751==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 49AE88982D for ; Fri, 17 May 2019 05:49:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0984854751== Content-Type: multipart/alternative; boundary="15580721800.c34a825.15658" Content-Transfer-Encoding: 7bit --15580721800.c34a825.15658 Date: Fri, 17 May 2019 05:49:40 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110257 67b0226d@casix.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from 67b0226d@casix.org --- Yes indeed, this bug is even listed in the 19.0.2 release notes. It was probably just forgotten to comment here. Anyhow, thanks Boyuan Zhang for the fix, works perfectly fine now with mesa 19.0.3 installed from normal repos! --=20 You are receiving this mail because: You are the assignee for the bug.= --15580721800.c34a825.15658 Date: Fri, 17 May 2019 05:49:40 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated 67b0226d@casix.org changed bug 11025= 7
What Removed Added
Status NEW RESOLVED
Resolution --- FIXED

Commen= t # 3 on bug 11025= 7 from 67b0226d@casix= .org
Yes indeed, this bug is even listed in the 19.0.2 release note=
s. It was
probably just forgotten to comment here. Anyhow, thanks Boyuan Zhang for the
fix, works perfectly fine now with mesa 19.0.3 installed from normal repos!=


You are receiving this mail because:
  • You are the assignee for the bug.
= --15580721800.c34a825.15658-- --===============0984854751== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0984854751==--