From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110671] Regression: DP outputs out of sync on dual-DP tiled 5k screen Date: Thu, 08 Aug 2019 20:41:59 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2045830150==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id BD5366E8C1 for ; Thu, 8 Aug 2019 20:41:59 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2045830150== Content-Type: multipart/alternative; boundary="15652969195.9EF729c.4990" Content-Transfer-Encoding: 7bit --15652969195.9EF729c.4990 Date: Thu, 8 Aug 2019 20:41:59 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110671 --- Comment #10 from Denys --- Just added some debug to rc3 and tried to check what happens(in context of 5fc0cbfad4564856ee0f323d3f88a7cff19cc3f1). So in program_timing_sync() there is preparing of groups of pipes for sync.= =20 And looks like(in my case) pipe_set[j]->plane_state is always true,=20 and all elements > 0 is removed from the pipe_set in this case,=20 hence group_size =3D=3D 1 and dc->hwss.enable_timing_synchronization() newer called. Contrary with old check !pipe_set[j]->stream_res.tg->funcs->is_blanked(pipe_set[j]->stream_res.tg) = is always false and we have our sync. Maybe it should be !pipe_set[j]->plane_state instead of pipe_set[j]->plane_state ? I applied this change to my 5.3.0-rc3 build and so far everything looks ok. I do not understand the purpose of is_blanked or plane_state, maybe with mst hubs or other stuff it may be a different story, but in my simple config it looks like just a typo. --=20 You are receiving this mail because: You are the assignee for the bug.= --15652969195.9EF729c.4990 Date: Thu, 8 Aug 2019 20:41:59 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 10 on bug 11067= 1 from = Denys
Just added some debug to rc3 and tried to check what happens(i=
n context of
5fc0cbfad4564856ee0f323d3f88a7cff19cc3f1).

So in program_timing_sync() there is preparing of groups of pipes for sync.=
=20
And looks like(in my case) pipe_set[j]->plane_state is always true,=20
and all elements > 0 is removed from the pipe_set in this case,=20
hence group_size =3D=3D 1 and dc->hwss.enable_timing_synchronization() n=
ewer
called.

Contrary with old check
!pipe_set[j]->stream_res.tg->funcs->is_blanked(pipe_set[j]->str=
eam_res.tg) is
always false and we have our sync.

Maybe it should be !pipe_set[j]->plane_state instead of
pipe_set[j]->plane_state ?
I applied this change to my 5.3.0-rc3 build and so far everything looks ok.

I do not understand the purpose of is_blanked or plane_state, maybe with mst
hubs or other stuff it may be a different story, but in my simple config it
looks like just a typo.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15652969195.9EF729c.4990-- --===============2045830150== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============2045830150==--